1435263 - Get rid of WorkerPrivateParent template

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P1)

Description

[Andrea Marchesini [:baku]]

This is going to be a multi patch bug in order to do this operation step by step.
Note that this is meant to apply on top of bug 1435174 and bug 1435196.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 0 - WorkerPrivate::EventTarget

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 1 - BusyCount and ParentStatus

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 2 - mMainThreadObjectsForgotten

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 3 - creation time

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 4 - LoadInfo, JSSettings, ParentFrozen, IsSecureContext and IsChromeWorker

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 5 - mParent

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 6 - ScriptURL and WorkerName

Comment 8

[Andrea Marchesini [:baku]]

Attachment: part 7 - WorkerType

Comment 9

[Andrea Marchesini [:baku]]

Attachment: part 8 - QueueRunnables, ParentWindowPauseDepth

Comment 10

[Andrea Marchesini [:baku]]

Attachment: part 9 - SharedWorkers

Comment 11

[Andrea Marchesini [:baku]]

Attachment: part 10 - PreStartRunnables

Comment 12

[Andrea Marchesini [:baku]]

Attachment: part 11 - Debugger

Comment 13

[Andrea Marchesini [:baku]]

Attachment: part 12 - Freeze/Thaw

Comment 14

[Andrea Marchesini [:baku]]

Attachment: part 13 - Start/Close/Kill/Terminate

Comment 15

[Andrea Marchesini [:baku]]

Attachment: part 14 - MaybeWrapAsWorkerRunnable and ProxyReleaseMainThreadObjects

Comment 16

[Andrea Marchesini [:baku]]

Attachment: part 15 - update methods

Comment 17

[Andrea Marchesini [:baku]]

Attachment: part 16 - Dispatch methods

Comment 18

[Andrea Marchesini [:baku]]

Attachment: part 17 - WorkerPrivateParent

Comment 19

[Andrea Marchesini [:baku]]

Attachment: part 18 - private/public sections

This last patch is just about having this format:

class WorkerPrivate
{
public:
  methods;

private:
  methods;
  members;
};

Comment 20

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8947827 [details] [diff] [review]
part 1 - BusyCount and ParentStatus

Review of attachment 8947827 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.h
@@ +910,5 @@
>    bool mOnLine;
>  
> +  // This is touched on parent thread only, but it can be read on a different
> +  // thread before crashing because hanging.
> +  Atomic<uint64_t> mBusyCount;

Can you put this before the bool members to improve packing?

Comment 21

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8947830 [details] [diff] [review]
part 3 - creation time

Review of attachment 8947830 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/WorkerPrivate.h
@@ +882,5 @@
>    // thread before crashing because hanging.
>    Atomic<uint64_t> mBusyCount;
>  
> +  TimeStamp mCreationTimeStamp;
> +  DOMHighResTimeStamp mCreationTimeHighRes;

Again, it would be nice if we put these before the bool members to improve packing.

Comment 22

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8947861 [details] [diff] [review]
part 18 - private/public sections

Review of attachment 8947861 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for all these improvements.  Maybe we could do one more patch or bug to make WorkerPrivate back optimally?  I think there are still some bool's mixed with other types, etc.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90740727f182
Get rid of WorkerPrivateParent template - part 0 - WorkerPrivate::EventTarget, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf0bb245dbb
Get rid of WorkerPrivateParent template - part 1 - BusyCount and ParentStatus, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0647c416bc2
Get rid of WorkerPrivateParent template - part 2 - mMainThreadObjectsForgotten, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fdd203c2ffb
Get rid of WorkerPrivateParent template - part 3 - creation time, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/853d78f5cbee
Get rid of WorkerPrivateParent template - part 4 - LoadInfo, JSSettings, ParentFrozen, IsSecureContext and IsChromeWorker, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c71b6887c78c
Get rid of WorkerPrivateParent template - part 5 - mParent, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d025bdc4c4b
Get rid of WorkerPrivateParent template - part 6 - ScriptURL and WorkerName, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/382d5387d9f9
Get rid of WorkerPrivateParent template - part 7 - WorkerType, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/93ad1a38b40c
Get rid of WorkerPrivateParent template - part 8 - QueueRunnables, ParentWindowPauseDepth, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e522b145b42
Get rid of WorkerPrivateParent template - part 9 - SharedWorkers, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d48000437e94
Get rid of WorkerPrivateParent template - part 10 - PreStartRunnables, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/f819bc8e2457
Get rid of WorkerPrivateParent template - part 11 - Debugger, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ca8a99e286a
Get rid of WorkerPrivateParent template - part 12 - Freeze/Thaw, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/20b7fc423f7d
Get rid of WorkerPrivateParent template - part 13 - Start/Close/Kill/Terminate, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/81af68b2de18
Get rid of WorkerPrivateParent template - part 14 - MaybeWrapAsWorkerRunnable and ProxyReleaseMainThreadObjects, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0c92aaeeff6
Get rid of WorkerPrivateParent template - part 15 - update methods, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3901faa7593e
Get rid of WorkerPrivateParent template - part 16 - Dispatch methods, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e8bbc7b68f
Get rid of WorkerPrivateParent template - part 17 - WorkerPrivateParent, r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c40197fd33e0
Get rid of WorkerPrivateParent template - part 18 - private/public sections, r=bkelly

Comment 24

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/90740727f182
https://hg.mozilla.org/mozilla-central/rev/daf0bb245dbb
https://hg.mozilla.org/mozilla-central/rev/c0647c416bc2
https://hg.mozilla.org/mozilla-central/rev/0fdd203c2ffb
https://hg.mozilla.org/mozilla-central/rev/853d78f5cbee
https://hg.mozilla.org/mozilla-central/rev/c71b6887c78c
https://hg.mozilla.org/mozilla-central/rev/3d025bdc4c4b
https://hg.mozilla.org/mozilla-central/rev/382d5387d9f9
https://hg.mozilla.org/mozilla-central/rev/93ad1a38b40c
https://hg.mozilla.org/mozilla-central/rev/1e522b145b42
https://hg.mozilla.org/mozilla-central/rev/d48000437e94
https://hg.mozilla.org/mozilla-central/rev/f819bc8e2457
https://hg.mozilla.org/mozilla-central/rev/7ca8a99e286a
https://hg.mozilla.org/mozilla-central/rev/20b7fc423f7d
https://hg.mozilla.org/mozilla-central/rev/81af68b2de18
https://hg.mozilla.org/mozilla-central/rev/d0c92aaeeff6
https://hg.mozilla.org/mozilla-central/rev/3901faa7593e
https://hg.mozilla.org/mozilla-central/rev/e6e8bbc7b68f
https://hg.mozilla.org/mozilla-central/rev/c40197fd33e0