Closed
Bug 1435370
Opened 6 years ago
Closed 6 years ago
Polish the shape path editor icon
Categories
(DevTools :: Inspector: Rules, enhancement, P2)
DevTools
Inspector: Rules
Tracking
(firefox61 verified, firefox62 verified)
VERIFIED
FIXED
Firefox 61
People
(Reporter: pbro, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The shape path editor icon in the rule-view is a little bit confusing, I think we could use a better one. Right now it's a rectangle with a diagonal line and 2 different colors. I don't think this represents a shape. Check the attached image. Now, maybe an actual polygon would make more sense. Something like this: https://thenounproject.com/search/?q=polygon&i=189082
Reporter | ||
Updated•6 years ago
|
Severity: normal → enhancement
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rcaliman
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8970843 [details] Bug 1435370 - Replace shape editor icon. https://reviewboard.mozilla.org/r/239628/#review245304
Attachment #8970843 -
Flags: review?(pbrosset) → review+
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df424e9d8910 Replace shape editor icon. r=pbro
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df424e9d8910
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Assignee | ||
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970843 [details] Bug 1435370 - Replace shape editor icon. https://reviewboard.mozilla.org/r/239628/#review245730 Replaced icon and increased size.
Attachment #8970843 -
Flags: review?(rcaliman) → review+
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6f5749b48d10 Replace shape editor icon. r=pbro
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6f5749b48d10
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Comment 9•6 years ago
|
||
Hi everyone, i have retested this issue on Windows 10 , Windows 7 , Mac OSx and Linux using the latest version of nightly 62.0a1 (2018-05-29) and i can Confirm it as Fixed. I will mark it accordingly.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•