1435473 - WebExtension's popup does not open after removed and reinstalled add-on that was moved to the customize from toolbar

Status: RESOLVED WORKSFORME

(WebExtensions :: Frontend, defect, P2)

Description

[magicp]

Attachment: steps-to-reproduce_20180203_113731.mp4

Steps to reproduce:
1. Launch Nightly
2. Install any add-ons which have a popup menu (e.g. Nightly Tester Tools)
3. Click the add-on button (Show popup correctly)
4. Right click on the add-on button and select "Remove from Toolbar" (The add-on button will move to the Customize)
5. Open the Add-ons Manager (Hamburger menu > Add-ons)
6. Remove the add-on and close Add-ons Manager
7. Open the Add-ons Manager again
8. Reinstall the add-on
9. Open the Customize (Hamburger menu > Customize...)
10. Right click on the add-on button and select "Add to Toolbar"
11. Click the add-on button in toolbar

Actual results
Popup does not open.

Expected results
Works fine.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af23e7b6eb9395aecf2a255316da782ca618750a&tochange=35acf942df34d075d1a181db6feeec0a9904f27b

Comment 1

[Kris Maglione [:kmag]]

Based on the regression range, this looks like a regression from bug 1401991. Any ideas, Mike?

Comment 2

[Mike de Boer [:mikedeboer]]

Well, hm, yes that may very well the culprit. It looks like it's easy to reproduce - magicgp, thanks for the detailed steps and video!

I don't have the cycles to work on this issue right now, but perhaps later. If this is/ becomes a high priority item to fix, I'd recommend to reach out so that someone can take a look!

Comment 3

[Shane Caraveo (:mixedpuppy)]

Looking into this.  My testing shows that the CUI panel has been added to the button, rather than our custom panel.  Weirder still is that every time the panel is opened, it switches between our custom panel and the cui panel.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Paolo, do you have any thoughts or input that can help here?

Comment 5

[:Paolo Amadini]

The panel code has changed significantly since the bug that regressed this was first filed, so if this still happens in the same way today, I suggest looking for the cause in the WebExtensions layer. Let me know if you have any questions about how the panel code is supposed to work!