Closed
Bug 1435568
Opened 6 years ago
Closed 6 years ago
Remove SVGUnitTypes values from elements
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file, 1 obsolete file)
|
5.38 KB,
patch
|
jwatt
:
review+
bkelly
:
review+
|
Details | Diff | Splinter Review |
This seems to be both what https://github.com/w3c/svgwg/issues/291 decided and what Chrome has implemented. There's a test here: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4581 It also makes using values from bindings in C++ easier as there aren't multiple copies of the same constant (albeit in different namespaces) floating around.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → longsonr
Attachment #8948189 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8948189 -
Attachment is obsolete: true
Attachment #8948189 -
Flags: review?(dholbert)
Attachment #8948243 -
Flags: review?(dholbert)
|
||
Updated•6 years ago
|
Attachment #8948243 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Comment on attachment 8948243 [details] [diff] [review] Don't need SVGUnitTypeValues at all now I need a DOM peer review too.
Attachment #8948243 -
Flags: review?(bkelly)
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8948243 [details] [diff] [review] Don't need SVGUnitTypeValues at all now Review of attachment 8948243 [details] [diff] [review]: ----------------------------------------------------------------- WebIDL changes look ok. It would be nice if the svg webidl files pointed to where the various interfaces are defined. Some of these are not in the main SVG spec, but things like css-masking AFAICT. Also, do we have WPT tests for SVG?
Attachment #8948243 -
Flags: review?(bkelly) → review+
|
||
Comment 5•6 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #4) > Also, do we have WPT tests for SVG? Looks like there are some in https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/svg (though those are mostly from upstream -- most of our own SVG test coverage is from reftests/mochitests right now).
|
|
Assignee | |
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7bf9f84937a4ef7f0585454b44e3b478b2d3939
|
|
Assignee | |
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a75b95370d69211234003d7e11066c0b96c0fdc
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4ffa63228d Remove SVGUnitTypes values from elements r=jwatt r=bkelly (DOM Peer)
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dd4ffa63228d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•