1435568 - Remove SVGUnitTypes values from elements

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Description

[Robert Longson [:longsonr]]

This seems to be both what https://github.com/w3c/svgwg/issues/291 decided and what Chrome has implemented.

There's a test here: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4581

It also makes using values from bindings in C++ easier as there aren't multiple copies of the same constant (albeit in different namespaces) floating around.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Robert Longson [:longsonr]]

Attachment: Don't need SVGUnitTypeValues at all now

Comment 3

[Robert Longson [:longsonr]]

Comment on attachment 8948243 [details] [diff] [review]
Don't need SVGUnitTypeValues at all now

I need a DOM peer review too.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8948243 [details] [diff] [review]
Don't need SVGUnitTypeValues at all now

Review of attachment 8948243 [details] [diff] [review]:
-----------------------------------------------------------------

WebIDL changes look ok.  It would be nice if the svg webidl files pointed to where the various interfaces are defined.  Some of these are not in the main SVG spec, but things like css-masking AFAICT.

Also, do we have WPT tests for SVG?

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Ben Kelly [:bkelly] from comment #4)
> Also, do we have WPT tests for SVG?

Looks like there are some in https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/svg (though those are mostly from upstream -- most of our own SVG test coverage is from reftests/mochitests right now).

Comment 6

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7bf9f84937a4ef7f0585454b44e3b478b2d3939

Comment 7

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a75b95370d69211234003d7e11066c0b96c0fdc

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd4ffa63228d
Remove SVGUnitTypes values from elements r=jwatt r=bkelly (DOM Peer)

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dd4ffa63228d