WebRTC fails to build with GCC 8

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
Rank:
25
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: zebob.m, Assigned: zebob.m)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8948350 [details] [diff] [review]
firefox-nightly-60.0a1-attributes_before_declarator.patch

When trying to build Firefox trunk with GCC 8, it fails with this error:

47:23.28 /builddir/build/BUILD/gecko-dev-0517a94d022c055b2cd0b519233fa8ef8b996d04/media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c:118:1: error: attributes should be specified before the declarator in a function definition
47:23.28  static inline int32_t OverflowingMulS16ByS32ToS32(int16_t a, int32_t b)
47:23.28  ^~~~~~


This was fixed upstream in commit d3cf0476b4c7923b6c0b8d25ce85769f6686b794: https://chromium.googlesource.com/external/webrtc.git/+/d3cf0476b4c7923b6c0b8d25ce85769f6686b794%5E%21/

I think you either need to backport this commit or update WebRTC to a more recent version.
Assignee: nobody → zebob.m
Rank: 25
Priority: -- → P3
Comment on attachment 8948350 [details] [diff] [review]
firefox-nightly-60.0a1-attributes_before_declarator.patch

Review of attachment 8948350 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, I'll land it for you assuming no problems show up on this try run: https://treeherder.mozilla.org/#/jobs?repo=try&author=dminor@mozilla.com
Attachment #8948350 - Flags: review+

Comment 2

a year ago
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de196fabad59
WebRTC fails to build with GCC 8; r=dminor

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/de196fabad59
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.