1435710 - [Dedicated profiles] During the initial profile cloning SyncID is cloned

Status: RESOLVED INVALID

(Toolkit :: Startup and Profile System, defect, P3)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]
-Ubuntu 16.04 x64
-Firefox 60.0a1 (trybuild from https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b67fc750f609d3eaa4097528528458e43bb4873&selectedJob=158774545)
-Firefox 58.0.1	20180128191252

[Pre-requisites:]
Delete all Firefox data and cache.

[Steps:]
1. Start Firefox 58.0.1 
2. Login to Sync.
3. Open about:config, search and record the value for services.sync.addons.syncID
4. Close Firefox 58.0.1 and start the Nightly try build that contains the dedicated profile feature.
5. Open about:config, search and record the value for services.sync.addons.syncID

[Actual Result:]
On step 4 - new profile is created(default-nightly) - (cloned after default) 
The syncID values for both versions are the same, which means that sync doesn't identify the two profiles: default (created at step1) and default-nightly (step4)

[Expected Result:]
The values for services.sync.addons.syncID are different for default and default-nightly profiles.

Comment 1

[Lina Butler [:lina]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #0)
> [Expected Result:]
> The values for services.sync.addons.syncID are different for default and
> default-nightly profiles.

Not quite. :-) `services.sync.addons.syncID`, and the other `.syncID` preferences, should be the same for all profiles connected to the same Sync account.

I think the only prefs that should be different are:

- services.sync.client.GUID
- services.sync.clients.lastRecordUpload
- services.sync.clients.lastModifiedOnProcessCommands
- services.sync.clients.lastSync
- services.sync.clients..lastSyncLocal
- Optionally, services.sync.client.name should be set to a unique device name.

Comment 2

[Adrian Florinescu [:aflorinescu]]

Thanks Kit for the additional details, the following prefs have the same values:

services.sync.client.GUID - copied
services.sync.clients.lastRecordUpload -copied
services.sync.clients.lastModifiedOnProcessCommands -couldn't find this pref.
services.sync.client.name - copied

Since I have moderate amount of knowledge about how sync works, I'm doing quite a few assumptions here. However, what I can tell at this moment is that synced tabs sidebar doesn't see two distinct profiles after cloning.

Comment 3

[Lina Butler [:lina]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #2)
> Since I have moderate amount of knowledge about how sync works, I'm doing
> quite a few assumptions here. However, what I can tell at this moment is
> that synced tabs sidebar doesn't see two distinct profiles after cloning.

No worries, Sync isn't wired up to support cloning profiles yet, so the buggy behavior you're seeing with the sidebar is "expected". :-/ Bug 1435917 is tracking the Sync work to support cloning.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Mark, since Dedicated profile branched into a different implementation approach, not using cloning at this point, (bug 1474285 ), I'm not sure where should be this issue tied to? IMO, this is still something that would be probably nice to have resolved, but I'm not sure to which component to move it if so: would it make more sense to sit in sync?

Comment 6

[Dave Townsend [:mossop]]

The profile cloning feature never shipped.