1435715 - No other action should be allowed when re-arranging tabs. Firefox will crash.

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Client-2018-02-05-161928.ips.beta

Build: 11.0 (8861)
Device: iPad Air 2
iOS: 11.2.5

Steps to reproduce:
1. Open two tabs
2. In the second tab go to youtube.com
3. Long tap on the youtube.com tab and move it in the 1st position
4. While still holding the finger on the youtube.com tab, close the empty tab.

Actual results:
- Firefox will crash. 

Expected results:
- Safari disables all buttons when holding the finger on a tab while re-arranging. We should do the same.

Note:
- Firefox also crashes when performing other actions (e.g. switching to private browsing, opening tabs) when holding the finger on a tab while re-arranging the tab.
- See video here: https://www.youtube.com/watch?v=k0bZhMSz0xE

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: Alternate Pull Request

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/43815a9b67797c1b0397ae5148751f1651abbb30

Landed on v11.x:

https://github.com/mozilla-mobile/firefox-ios/commit/213cb04442cf6bb15ec5c5c6fd68858b3d3e8737

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on 11.0(9266). The crash is no longer reproducible when performing other actions (e.g. switching to private browsing, opening tabs) when dragging tabs to re-arrange them.