1435736 - The tab at end of tabstrip can’t be hidden

Status: RESOLVED INVALID

(WebExtensions :: Frontend, defect)

Description

[CosminB]

Attachment: UnhiddenTab.gif

[Affected versions]:
- Firefox 60.0a1 (20180204220351)
- Firefox 59.0b6 (20180201171410)

[Affected platforms]:
- Win 7 64-bit
- Mac OS X 10.13.2

[Steps to reproduce]:
1.Install https://addons.mozilla.org/en-US/firefox/addon/hide-tab/.
2.Open multiple tabs.
3.Select the penultimate tab.
4.Hide the tab.
5.The last tab is in focus.
6.Try to hide the last tab.

[Expected results]:
- The last tab is hidden without any issues.

[Actual results]:
- The last tab can't be hidden at all, even if you restart the browser.

Please see the attached video.

Comment 1

[Shane Caraveo (:mixedpuppy)]

This is by design, you cannot hide the active tab.

Comment 2

[brunoais]

He was able to hide the active tab, though. See the first part of the example in the attachment.
New bug?

Comment 3

[Shane Caraveo (:mixedpuppy)]

I don't know what the extension is doing internally, perhaps it is switching to a different tab then hiding the one that was selected.  Based on the tabHide logic[1], the selected tab should not be hide-able.  Perhaps the reporter can explain what the logic in the extension is.

[1] https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3899

Comment 4

[Shane Caraveo (:mixedpuppy)]

Just looked at the extension, it does indeed seem that it is switching tabs then hiding the tab.  My assumption is an error in the logic for the last tab.

Comment 5

[Shane Caraveo (:mixedpuppy)]

It's also not the "last tab", which I took as meaning there was only one visible tab in the window.

Comment 6

[brunoais]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> Just looked at the extension, it does indeed seem that it is switching tabs
> then hiding the tab.  My assumption is an error in the logic for the last
> tab.

I was making a comment exactly about that. It only tries to change to the next tab and there's no next tab to change to.