Deprecate RTCIceCandidateStats.mozLocalTransport and add protocol and relayProtocol

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
Rank:
25
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: ng, Assigned: ng)

Tracking

({dev-doc-complete, site-compat})

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
There is a comment in RTCStatsReport.webidl RTCIceCandidates that mozLocalTransport needs statndardizing [1].
The line was added in bug 970690.
[1] https://searchfox.org/mozilla-central/rev/01d663157f5796f0280f8b68f2308e7c19dd72c6/dom/webidl/RTCStatsReport.webidl#157

Could someone familiar with the field comment as to whether it still needs a bug filed against the spec?
(Assignee)

Updated

a year ago
Flags: needinfo?(drno)
Flags: needinfo?(docfaraday)
It looks like the spec is covering this a little differently than we are. The spec has two attributes, "protocol" and "relayProtocol". "protocol" is set to the transport protocol of the candidate (ie; what the other end will use to reach us). In the case of relay, this might be different from the local transport protocol, which will be stored in "relayProtocol". Otherwise, "relayProtocol" won't be set. In other words, c.mozLocalTransport = c.relayProtocol || c.protocol.
Flags: needinfo?(docfaraday)
(Assignee)

Comment 2

a year ago
Thanks, Byron. Ok, I am changing this bug to deprecating what we have in favor of implementing the spec.
Flags: needinfo?(drno)
Summary: Standardize RTCIceCandidateStats.mozLocalTransport → Deprecate RTCIceCandidateStats.mozLocalTransport and add protocol and relayProtocol
(Assignee)

Updated

a year ago
Assignee: nobody → na-g
Nico, please add appropriate priorities for this one, it's unclear if it's short or long term. Also, can you move it to the right component? Thanks!
Flags: needinfo?(na-g)
(Assignee)

Updated

a year ago
Rank: 25
Component: WebRTC → WebRTC: Networking
Flags: needinfo?(na-g)
Priority: -- → P3
is there a good way to have a relayed connection in the test?
(Assignee)

Comment 6

8 months ago
Comment on attachment 9001318 [details]
Bug 1435789: implement relayProtocol for localcandidate stats

Nico Grunbaum [:ng] has approved the revision.
Attachment #9001318 - Flags: review+
Comment on attachment 9001318 [details]
Bug 1435789: implement relayProtocol for localcandidate stats

Olli Pettay [:smaug] has approved the revision.
Attachment #9001318 - Flags: review+
(Assignee)

Updated

7 months ago
Blocks: 1498652

Comment 8

6 months ago
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b32ff85f2224
implement relayProtocol for localcandidate stats r=smaug,ng

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b32ff85f2224
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Note to docs team:

I've added a note to the Fx 64 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#APIs

Doesn't look like we've documented RTCIceCandidateStats at all, so there's a bit of work to do here.
Documentation has been written.

Pages added:

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats
https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/address
https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/relayProtocol

mozLocalTransport is set up as a redirect to relayProtocol as well.

Change already on Firefox 64 for developers, as mentioned above.
Replaced that redirect with an actual page with more useful info, since it's not a 1:1 replacement:

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidateStats/mozLocalTransport
You need to log in before you can comment on or make changes to this bug.