Closed Bug 1435889 Opened 2 years ago Closed 2 years ago

List sources generated by midl in moz.build rather than Makefile.in

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

We have enough info in moz.build to do this simply. We need to emit a proper sources object for bug 1429875 to work
I had thought about this a few times recently. I think we could probably replace all the MIDL stuff with just moz.build templates nowadays. The stuff currently in makefiles groups IDL files into separate sets depending on whether they turn into sources or not etc:
https://dxr.mozilla.org/mozilla-central/rev/ef1fefe4c6d1f95e2bdf872094e02e85c962aa86/accessible/interfaces/ia2/Makefile.in#15

If we had a generic `Midl(names, source=False, typelib=False, ...)` template that did like `for name in names: GENERATED_FILES += (name.replace('.idl', '_p.c'), name.replace('.idl', '.h), ...)` then we could make other templates that used that template like   `MidlSources(names): Midl(names, source=True)`.
That being said, if you have a simpler half-measure in mind to unblock bug 1429875 then let's do that. I certainly don't want to rathole you on a bunch of other work!
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> That being said, if you have a simpler half-measure in mind to unblock bug
> 1429875 then let's do that. I certainly don't want to rathole you on a bunch
> of other work!

Yeah, I'm inclined to do the minimal obvious thing for now, but the full fix doesn't seem that bad, either.
Comment on attachment 8948578 [details]
Bug 1435889 - List sources generated by midl in accessible/interfaces/ia2 in moz.build rather than Makefile.in

https://reviewboard.mozilla.org/r/217994/#review223796
Attachment #8948578 - Flags: review+
Attachment #8948578 - Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/853e25b18469
List sources generated by midl in accessible/interfaces/ia2 in moz.build rather than Makefile.in r=nalexander
https://hg.mozilla.org/mozilla-central/rev/853e25b18469
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.