1435889 - List sources generated by midl in moz.build rather than Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

We have enough info in moz.build to do this simply. We need to emit a proper sources object for bug 1429875 to work

Comment 1

[(not currently active) Ted Mielczarek]

I had thought about this a few times recently. I think we could probably replace all the MIDL stuff with just moz.build templates nowadays. The stuff currently in makefiles groups IDL files into separate sets depending on whether they turn into sources or not etc:
https://dxr.mozilla.org/mozilla-central/rev/ef1fefe4c6d1f95e2bdf872094e02e85c962aa86/accessible/interfaces/ia2/Makefile.in#15

If we had a generic `Midl(names, source=False, typelib=False, ...)` template that did like `for name in names: GENERATED_FILES += (name.replace('.idl', '_p.c'), name.replace('.idl', '.h), ...)` then we could make other templates that used that template like   `MidlSources(names): Midl(names, source=True)`.

Comment 2

[(not currently active) Ted Mielczarek]

That being said, if you have a simpler half-measure in mind to unblock bug 1429875 then let's do that. I certainly don't want to rathole you on a bunch of other work!

Comment 3

[Chris Manchester (limited bugmail, email directly)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> That being said, if you have a simpler half-measure in mind to unblock bug
> 1429875 then let's do that. I certainly don't want to rathole you on a bunch
> of other work!

Yeah, I'm inclined to do the minimal obvious thing for now, but the full fix doesn't seem that bad, either.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1435889 - List sources generated by midl in accessible/interfaces/ia2 in moz.build rather than Makefile.in

Review commit: https://reviewboard.mozilla.org/r/217994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217994/

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8948578 [details]
Bug 1435889 - List sources generated by midl in accessible/interfaces/ia2 in moz.build rather than Makefile.in

https://reviewboard.mozilla.org/r/217994/#review223796

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/853e25b18469
List sources generated by midl in accessible/interfaces/ia2 in moz.build rather than Makefile.in r=nalexander

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/853e25b18469