"ImportError: No module named jsonschema" when running talos test locally with geckoProfiler

RESOLVED FIXED in Firefox 60

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: xidorn, Assigned: jmaher)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [PI:February])

Attachments

(1 attachment, 1 obsolete attachment)

I ran
> MOZ_UPLOAD_DIR=../profiling/tresize ./mach talos-test --cycles 2 -a tresize --setpref=layout.css.servo.chrome.enabled=true --geckoProfile

and I saw
> FATAL - Uncaught exception: Traceback (most recent call last):
> FATAL -   File "\testing\mozharness\mozharness\base\script.py", line 2059, in run
> FATAL -     self.run_action(action)
> FATAL -   File "\testing\mozharness\mozharness\base\script.py", line 1998, in run_action
> FATAL -     self._possibly_run_method(method_name, error_if_missing=True)
> FATAL -   File "\testing\mozharness\mozharness\base\script.py", line 1938, in _possibly_run_method
> FATAL -     return getattr(self, method_name)()
> FATAL -   File "\testing\mozharness\mozharness\mozilla\testing\talos.py", line 747, in run_tests
> FATAL -     self._validate_treeherder_data(parser)
> FATAL -   File "\testing\mozharness\mozharness\mozilla\testing\talos.py", line 611, in _validate_treeherder_data
> FATAL -     import jsonschema
> FATAL -   File "\build/mach_bootstrap.py", line 363, in __call__
> FATAL -     module = self._original_import(name, globals, locals, fromlist, level)
> FATAL - ImportError: No module named jsonschema
> FATAL - Running post_fatal callback...
> FATAL - Exiting -1
in the log.

After I pip install jsonschema, this fatal error no longer shows up (although I still cannot find the profile result).
Looks like I don't really need to set MOZ_UPLOAD_DIR and actually it's useless. The harness would set it to testing/mozharness/build/blobber_upload_dir itself...
Whiteboard: [PI:February]
this is broken in general unrelated to geckoProfile, let me work on fixing this.
Comment on attachment 8949386 [details] [diff] [review]
add jsconschema to the requirements.txt file

we do not have jsonschema 2.6.0 in our pypi pip cache.  I will find what we have and verify that works, or get 2.6.0 uploaded
Attachment #8949386 - Flags: review?(rwood)
and it appears we have 2.5.1 already on internal pypi and that works just fine.
Attachment #8949386 - Attachment is obsolete: true
Attachment #8949405 - Flags: review?(rwood)
Comment on attachment 8949405 [details] [diff] [review]
add jsonschema to the requirements.txt file

Review of attachment 8949405 [details] [diff] [review]:
-----------------------------------------------------------------

r+ and works for me on OSX

*** Note: To get this fix you'll have to blow away your /talos-venv/ to force a new install of the updated requirements.

i.e. on OSX: obj-x86_64-apple-darwin17.4.0/testing/talos-venv/
Attachment #8949405 - Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd0b54fe857
"ImportError: No module named jsonschema". r=rwood
https://hg.mozilla.org/mozilla-central/rev/6fd0b54fe857
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.