Closed
Bug 1435907
Opened 6 years ago
Closed 6 years ago
"ImportError: No module named jsonschema" when running talos test locally with geckoProfiler
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: xidorn, Assigned: jmaher)
Details
(Whiteboard: [PI:February])
Attachments
(1 file, 1 obsolete file)
449 bytes,
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
I ran > MOZ_UPLOAD_DIR=../profiling/tresize ./mach talos-test --cycles 2 -a tresize --setpref=layout.css.servo.chrome.enabled=true --geckoProfile and I saw > FATAL - Uncaught exception: Traceback (most recent call last): > FATAL - File "\testing\mozharness\mozharness\base\script.py", line 2059, in run > FATAL - self.run_action(action) > FATAL - File "\testing\mozharness\mozharness\base\script.py", line 1998, in run_action > FATAL - self._possibly_run_method(method_name, error_if_missing=True) > FATAL - File "\testing\mozharness\mozharness\base\script.py", line 1938, in _possibly_run_method > FATAL - return getattr(self, method_name)() > FATAL - File "\testing\mozharness\mozharness\mozilla\testing\talos.py", line 747, in run_tests > FATAL - self._validate_treeherder_data(parser) > FATAL - File "\testing\mozharness\mozharness\mozilla\testing\talos.py", line 611, in _validate_treeherder_data > FATAL - import jsonschema > FATAL - File "\build/mach_bootstrap.py", line 363, in __call__ > FATAL - module = self._original_import(name, globals, locals, fromlist, level) > FATAL - ImportError: No module named jsonschema > FATAL - Running post_fatal callback... > FATAL - Exiting -1 in the log. After I pip install jsonschema, this fatal error no longer shows up (although I still cannot find the profile result).
Reporter | ||
Comment 1•6 years ago
|
||
Looks like I don't really need to set MOZ_UPLOAD_DIR and actually it's useless. The harness would set it to testing/mozharness/build/blobber_upload_dir itself...
Assignee | ||
Updated•6 years ago
|
Whiteboard: [PI:February]
Assignee | ||
Comment 2•6 years ago
|
||
this is broken in general unrelated to geckoProfile, let me work on fixing this.
Assignee | ||
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c63d4c73d1a8d8fb9c92449f57ef04e0e772f306
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 8949386 [details] [diff] [review] add jsconschema to the requirements.txt file we do not have jsonschema 2.6.0 in our pypi pip cache. I will find what we have and verify that works, or get 2.6.0 uploaded
Attachment #8949386 -
Flags: review?(rwood)
Assignee | ||
Comment 5•6 years ago
|
||
and it appears we have 2.5.1 already on internal pypi and that works just fine.
Attachment #8949386 -
Attachment is obsolete: true
Attachment #8949405 -
Flags: review?(rwood)
Comment 6•6 years ago
|
||
Comment on attachment 8949405 [details] [diff] [review] add jsonschema to the requirements.txt file Review of attachment 8949405 [details] [diff] [review]: ----------------------------------------------------------------- r+ and works for me on OSX *** Note: To get this fix you'll have to blow away your /talos-venv/ to force a new install of the updated requirements. i.e. on OSX: obj-x86_64-apple-darwin17.4.0/testing/talos-venv/
Attachment #8949405 -
Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6fd0b54fe857 "ImportError: No module named jsonschema". r=rwood
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6fd0b54fe857
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•