Closed Bug 1435931 Opened 7 years ago Closed 6 years ago

Scrolling performance on github really bad when text selected

Categories

(Core :: Layout: Text and Fonts, defect, P3)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1464632

People

(Reporter: jrmuizel, Unassigned)

References

Details

Scrolling this page https://github.com/trizinix/afm-rs/blob/master/src/lib.rs with text selected gives profiles like: https://perfht.ml/2E710v9 and https://perfht.ml/2E3zGxW 84% of the time is being spent in nsIFrame::IsSelected()
Blocks: 1435932
See also bug 1374338
Priority: -- → P3
Alexis, do you recall what the conclusion about text selection on github was?
Flags: needinfo?(a.beingessner)
The issue seems to be that an array-backed cache was removed from a linked-list data structure for maintenance/perf reasons elsewhere, but this part of the code does binary search on that list. This erratic access pattern also breaks any attempt to do locality-based caching of the list. I'll inquire into what we can do about it.
Flags: needinfo?(a.beingessner)
see also bug 1464632 (which could be a dupe). It has some discussion from the layout people
this is fixed by bug 1464632
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.