1435938 - Add basic logging for DrawTargetCapture

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

I've hacked up logging for DrawCommand's in a DrawTargetCapture one too many times, so I wrote a patch which adds some basic logging.

More complicated things, like SourceSurfaces, Paths, and AlphaBoxBlurs are not printed in the logs. The logging can be extended if that is ever desired.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (,

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: capture-log-1.patch

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: capture-log-2.patch

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Add basic DrawTargetCapture logging ability (bug 1435938, )

Review commit: https://reviewboard.mozilla.org/r/218026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218026/

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (bug 1435938, )

Review commit: https://reviewboard.mozilla.org/r/218028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218028/

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

Whoops. Please ignore my mess of uploading the patches..

Comment 7

[Bas Schouten (:bas.schouten)]

Comment on attachment 8948612 [details]
Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (bug 1435938, )

https://reviewboard.mozilla.org/r/218028/#review224532

Comment 8

[Bas Schouten (:bas.schouten)]

Comment on attachment 8948611 [details]
Add basic DrawTargetCapture logging ability (bug 1435938, )

https://reviewboard.mozilla.org/r/218026/#review224538

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db4018b4b695
Add basic DrawTargetCapture logging ability (bug 1435938, r=bas)
https://hg.mozilla.org/integration/mozilla-inbound/rev/b24907f82186
Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (bug 1435938, r=bas)

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for rusttest failures

Push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b24907f82186f293051e4e88d1f01562cc210fc0

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/05855884fc04c1b03393717e9ff86dd7a8991d05

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=161344609&repo=mozilla-inbound&lineNumber=34149

[task 2018-02-09T16:02:54.028Z] 16:02:54     INFO - error: test failed, to rerun pass '--lib'
[task 2018-02-09T16:02:54.028Z] 16:02:54     INFO - /builds/worker/workspace/build/src/config/rules.mk:990: recipe for target 'force-cargo-test-run' failed
[task 2018-02-09T16:02:54.028Z] 16:02:54     INFO - make[2]: *** [force-cargo-test-run] Error 101
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - make[2]: Target 'check' not remade because of errors.
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust'
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - /builds/worker/workspace/build/src/config/recurse.mk:100: recipe for target 'toolkit/library/rust/check' failed
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - make[1]: *** [toolkit/library/rust/check] Error 2
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - make[1]: Target 'recurse_check' not remade because of errors.
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2018-02-09T16:02:54.029Z] 16:02:54     INFO - /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'check' failed
[task 2018-02-09T16:02:54.030Z] 16:02:54     INFO - make: *** [check] Error 2
[task 2018-02-09T16:02:54.047Z] 16:02:54     INFO - Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2018-02-09T16:02:54.059Z] 16:02:54    ERROR - Return code: 2
[task 2018-02-09T16:02:54.060Z] 16:02:54     INFO - TinderboxPrint: check<br/>32/0/0
[task 2018-02-09T16:02:54.060Z] 16:02:54  WARNING - setting return code to 2
[task 2018-02-09T16:02:54.060Z] 16:02:54    ERROR - 'mach build check' did not run successfully. Please check log for errors.
[task 2018-02-09T16:02:54.060Z] 16:02:54     INFO - [mozharness: 2018-02-09 16:02:54.060577Z] Finished check-test step (success)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48a7b3be6436
Add basic DrawTargetCapture logging ability (bug 1435938, r=bas)
https://hg.mozilla.org/integration/mozilla-inbound/rev/22b661e7c5a4
Add 'layers.omtp.dump-capture' for logging DrawTargetCapture (bug 1435938, r=bas)

Comment 12

[Ryan Hunt [:rhunt] (on leave until early May)]

The problem was resolved by marking 'mozilla::external::AtomicRefcount' as opaque in ServoBindings.toml.

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/48a7b3be6436
https://hg.mozilla.org/mozilla-central/rev/22b661e7c5a4