1435942 - Fix buggy getters in Preferences.h

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1435942 - Fix buggy getters in Preferences.h.

They currently fail to pass on `aKind`, always getting the user value (when
possible). There are three callsites that are affected:

- nsSHistory::Startup, docshell/shistory/nsSHistory.cpp.
- FeatureState::SetDefaultFromPref(), in gfx/config/gfxFeature.cpp.
- gfxPlatform::InitOMTPConfig(), in gfx/thebes/gfxPlatform.cpp.

The patch also adds a gtest that would have failed prior to the fix.

Review commit: https://reviewboard.mozilla.org/r/218036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218036/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8948618 [details]
Bug 1435942 - Fix buggy getters in Preferences.h.

https://reviewboard.mozilla.org/r/218036/#review223828

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/caf379dce6b1744e4d0c6cc1388979ad85c6f1a7
Bug 1435942 - Fix buggy getters in Preferences.h. r=glandium

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/caf379dce6b1