1436018 - Disable Stylo microbenchmark on Windows

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Ionuț Goldan [:igoldan]]

Proposal originated here [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1434213#c22

Comment 1

[Ionuț Goldan [:igoldan]]

Attachment: Bug 1436018 - Disable Stylo microbenchmark on Windows

Review commit: https://reviewboard.mozilla.org/r/233248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233248/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8964516 [details]
Bug 1436018 - Disable Stylo microbenchmark on Windows

https://reviewboard.mozilla.org/r/233248/#review238764

really close

::: layout/style/test/gtest/StyloParsingBench.cpp
(Diff revision 1)
>                                       nullptr)
>          .Consume();
>    }
>  }
>  
> -MOZ_GTEST_BENCH(Stylo, Servo_StyleSheet_FromUTF8Bytes_Bench, ServoParsingBench);

if we remove this, then we should remove the ServoParsingBench method above.

::: layout/style/test/gtest/StyloParsingBench.cpp:111
(Diff revision 1)
> +MOZ_GTEST_BENCH(Stylo, Servo_DeclarationBlock_SetPropertyById_WithInitialSpace_Bench, [] {
> +  ServoSetPropertyByIdBench(NS_LITERAL_CSTRING(" 10px"));
> +});
>  
> +MOZ_GTEST_BENCH(Stylo, Servo_DeclarationBlock_GetPropertyById_Bench, ServoGetPropertyValueById);
> +#endif 

nit: trailing whitespace here.

Comment 3

[Ionuț Goldan [:igoldan]]

Comment on attachment 8964516 [details]
Bug 1436018 - Disable Stylo microbenchmark on Windows

https://reviewboard.mozilla.org/r/233248/#review238764

> if we remove this, then we should remove the ServoParsingBench method above.

I haven't removed that function call. I've only grouped it with the others, to easily silence them on Windows.

Comment 4

[Ionuț Goldan [:igoldan]]

Comment on attachment 8964516 [details]
Bug 1436018 - Disable Stylo microbenchmark on Windows

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233248/diff/1-2/

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8964516 [details]
Bug 1436018 - Disable Stylo microbenchmark on Windows

https://reviewboard.mozilla.org/r/233248/#review238798

thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42176ad3be1e
Disable Stylo microbenchmark on Windows r=jmaher

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/42176ad3be1e