1436041 - Opening add-on page during it's upgrade may cause incorrectly loaded add-on page

Status: RESOLVED DUPLICATE of bug 1490260

(WebExtensions :: General, defect)

Description

[juraj.masiar]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180201171410

Steps to reproduce:

My add-on is overriding "New tab" page. If add-on is being upgraded and the user opens the new tab page, it may result into partially loaded add-on page.
See the video:
https://youtu.be/PIKMve7Vdqg

Steps:
1) prepare old add-on :)
2) trigger the upgrade
3) open several new tabs using "Ctrl + T"


Actual results:

The result tabs can be divided into 4 groups:
1) first group of tabs are add-on pages that were opened before the add-on was upgraded and were closed afterwards (you can see that in the video)
2) second group of tabs are partially loaded add-on pages - sometimes with error that the "chrome" is undefined, sometimes with error that loading of JavaScript files failed
3) third group of tabs are the default "New tab" pages, that were loaded while add-on is being upgraded and is not available
4) forth group are correctly loaded add-on pages after the upgrade


Expected results:

In the ideal world, I would like to have
1) add-on pages to be reloaded, not closed
2) default pages not to be loaded, but waiting for the overriding add-on to be upgraded
3) 0 tabs with errors loading resources or using "chrome" API

In less ideal world I would just like to see 0 tabs with errors.

Even though the chance for opening new tab page during it's upgrade is small, if your add-on is used by 50 000 users than 50 000 * small = several complaining users with every new release.

Comment 1

[juraj.masiar]

Attachment: bug demonstration