Closed Bug 1436057 Opened 6 years ago Closed 6 years ago

Pages with keyboard shortcuts intercept browser Ctrl-key shortcuts

Categories

(Firefox :: Untriaged, defect)

59 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1433592

People

(Reporter: e.treuherz, Unassigned)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101

Steps to reproduce:

This seems to be a problem from several sites with keyboard shortcuts. Will use GitHub as an example. From any GitHub code page, pressing ? gives a list of keyboard shortcuts. Several, (such as S to search, L to jump to a line), are keys also used in browser Ctrl-key shortcuts, (Ctrl-S to save, Ctrl-L to focus on the address bar). Try pressing Ctrl-L.

Have only tested on Firefox 59.0b6 (64-bit) on Windows 7 Enterprise SP1.


Actual results:

GitHub receives an L shortcut, and brings up the jump to line dialog.


Expected results:

Ctrl-L should move focus to the address bar
OS: Unspecified → Windows 7
Hardware: Unspecified → x86_64
I can confirm this for Firefox Nightly 60.0a1 (2018-02-06) (64-bit) on Arch Linux. This also affects all pages where Vimium is active.
Also causes all Ctrl-shortcuts that should be passed through to Google Docs as Ctrl-shortcuts (e.g. Ctrl-C, Ctrl-X, Ctrl-V, Ctrl-Z) to pass through as just the key (C, X, V, Z)
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180209005628

I have not managed to reproduce the issue on Windows 7 x64, Windows 10 x64, Arch Linux and Mac 10.13, with Firefox release (58.0.2), Firefox beta (59.0b7) and the latest Nightly (60.0a1) build. 
I've navigated to the "https://github.com/mozilla/notes" page, I've pressed "Ctrl+L" key combination and the "Address Bar" was focused. On the other hand, pressing "L" alone does not do anything for me.

Could you please tell us specifically where are you using the key combinations? Also do you have any add-ons installed (maybe one of those generates a conflict)? 

Lastly could you please retest this issue using a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/AR5o9d)?
Flags: needinfo?(e.treuherz)
(In reply to Marius Coman [:cmarius] from comment #3)
> I've navigated to the "https://github.com/mozilla/notes" page, I've pressed
> "Ctrl+L" key combination and the "Address Bar" was focused. On the other
> hand, pressing "L" alone does not do anything for me.
I can't test it right now, but the issue only happens if the page intercepts the key. If you open a text file on Github, https://github.com/mozilla/notes/blob/master/LICENSE for example, where pressing 'l' (lowercase L) can be used to jump to a line, Ctrl+L doesn't focus the address bar. Instead, the jump-to-line dialog appears. 

> Could you please tell us specifically where are you using the key
> combinations? Also do you have any add-ons installed (maybe one of those
> generates a conflict)?
I have confirmed the issue with only uBlock Origin active. Will test with all add-ons disabled when I have time, maybe today.

> Lastly could you please retest this issue using a new clean Firefox profile,
> maybe even safe mode, to eliminate custom settings as a possible cause
> (https://goo.gl/AR5o9d)?
I will try this and report the results. Maybe I have time today, when I get home.
I tried safe mode on my customized profile, but the problem remains. However, the bug seems gone when creating a new profile. Ctrl-L on https://github.com/mozilla/notes/blob/master/LICENSE correctly gives focus to the address bar, even after installing the same addons (uBlock Origin and Vimium) and restoring their settings from a backup file.

So it seems there's a problem with my profile, but I have no clue what or how.

Let me know if you need more information.
Could you please provide the "pref.js" file from the "affected" user profile and the "pref.js" from the "unaffected" profile. 
In order to find each of the "pref.js" files, open the browser with the desired profile, navigate to the "about:support" page and click on the "Open Folder" button from the "Profile Folder" line.
Also, can you please post a copy after the "about:support" page?
Flags: needinfo?(willemvandekrol)
Tested using Firefox 60.0a1 (2018-02-13) (64-bit) on Arch Linux
Flags: needinfo?(willemvandekrol)
Tested using Firefox 60.0a1 (2018-02-13) (64-bit) on Arch Linux
I have attached both prefs.js files.

While trying to reproduce the bug on my new profile, I found privacy.resistFingerprinting is the cause. When enabling this option in about:config, Ctrl-L on https://github.com/mozilla/notes/blob/master/LICENSE suddenly starts misbehaving, without restarting or reloading the page.
Have been away from the affected machine for a few days, thanks for going through all this effort here, Willem. My profile has privacy.resistFingerprinting active as well. Can check turning the setting off fixes the issue when I get back to the office but it sounds like you’ve found it!
Flags: needinfo?(e.treuherz)
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: