1436066 - Incorrect appearance for RTL content inside Simplify Page

Status: NEW

(Toolkit :: Printing, defect, P3)

Description

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Attachment: Screenshot showing the issue

[Affected versions]:
- 60.0a1

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Open Firefox with a RTL language build (eg. arabic)
2. Go to https://goo.gl/JvPWSq
3. Enter the Reader view mode (click on the book icon inside the address bar)
4. Observe the content alignment
5. Exit the Reader view mode (click again on the book icon inside the address bar)
6. Enter the print preview (menu - print icon)
7. Enter in Simplify Page (click on the  button with the checkbox)
8. Observe the content alignment

[Expected result]:
- In both, Reader view and Simplify Page the content is aligned to the right.

[Actual result]:
- The content inside the Reader view is  aligned to the right, while in Simplify Page is aligned to the left.

[Regression range]:
- I don’t think this is a regression, older builds have the same behaviour way back to 54.0a1 (2017-02-01). I couldn't verify this issue on older builds. On 54.0a1 (2017-01-31) when clicking on Simplify Page button a white empty page is displayed and on 53.0a1 (2016-12-14) I encountered a tab crash once I click on the Print icon.

[Additional notes]:
- Note that when the content is displayed in a LTR language (although in a RTL language build),  the alignment is to the left in both Reader View and Simplify Page.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO: May 24 - June 2nd)]

Hey mlongaray, do you have cycles / interest in looking at this bug?

Comment 2

[Matheus Longaray (:mlongaray)]

Hey Mike, sorry the delay, I've been swamped in the past few weeks. I'm not sure if I'll have the cycles in the next two weeks, maybe after that. I'll keep you posted.

Comment 3

[Matheus Longaray (:mlongaray)]

Mike, do you have any pointers on what might be causing this? I've never been involved with how different language builds work. That'd be a lot of help. I might get someone to start ramping on the Simplify work so we can have greater bandwidth.

Comment 4

[:Gijs (he/him)]

(In reply to Matheus Longaray (:mlongaray) from comment #3)
> Mike, do you have any pointers on what might be causing this? I've never
> been involved with how different language builds work. That'd be a lot of
> help. I might get someone to start ramping on the Simplify work so we can
> have greater bandwidth.

If I had to guess, look for instances of `rtl` or `dir` in aboutreader files (css/js), and where that's out of sync with what we do with simplify page (given comment #0 says reader mode does work correctly in this case).

To test without an RTL build, you can use about:config and set `intl.uidirection` to the value 1 (default is -1, which uses the direction of the locale that's in use). Checking briefly, I can reproduce like that, and I see that a number of readability container elements have a `dir=rtl` attribute in reader mode, but not in simplify page... Does that help?