1436186 - DocGroup::GetKey isn't precise enough

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently it just uses nsIPrincipal::GetBaseDomain, when (I believe) it should also take the protocol and port into account.

Comment 1

[Anne (:annevk)]

Nika, could you please set a priority for this? (Without priority it shows up in triaging, and you'll get bugged by people like me. Sorry.)

Comment 2

[Nika Layzell [:nika] (ni? for response)]

This currently has no real impact, but it might in the future.

Comment 3

[Anne (:annevk)]

I think Principal should get a GetSite() method that follows https://html.spec.whatwg.org/#obtain-a-site and then we use that here. (Note that it usually would not take port into account which is correct as document.domain can unfortunately cross that boundary.)

The other thing here is that we should probably take origin attributes into account as well.

Comment 4

[Anne (:annevk)]

It seems this was fixed in bug 1601594, though there is still a comment there about GetBaseDomain: https://searchfox.org/mozilla-central/source/dom/base/DocGroup.cpp#154-166. The other slightly weird nomenclature there is "SiteOrigin". It would be nicer if we used Site here as well, similar to the refactoring from bug 1731739 comment 5.