Closed
Bug 1436207
Opened 7 years ago
Closed 7 years ago
Optimize inserting synced bookmark URLs into Places
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1436207 - Use a subquery instead of a left join when inserting synced bookmark URLs into Places.
59 bytes,
text/x-review-board-request
|
markh
:
review+
|
Details |
https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/toolkit/components/places/SyncedBookmarksMirror.jsm#1025-1026 should be a subquery, not a LEFT JOIN. It takes over 4 minutes to insert 40k new URLs with the join; 2 seconds with a subquery.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8948836 [details]
Bug 1436207 - Use a subquery instead of a left join when inserting synced bookmark URLs into Places.
https://reviewboard.mozilla.org/r/218210/#review224028
nice!
Attachment #8948836 -
Flags: review?(markh) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b47ba60052e5
Use a subquery instead of a left join when inserting synced bookmark URLs into Places. r=markh
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•