Closed
Bug 1436210
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend v14
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file)
|
193.33 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8948994 -
Flags: review?(jdescottes)
|
|
Assignee | |
Comment 5•7 years ago
|
||
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8948994 [details] [diff] [review]
rel14.patch
Review of attachment 8948994 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. Talos at https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=d28a38736517c98deda5657e22899b9901a714aa
Attachment #8948994 -
Flags: review?(jdescottes) → review+
|
|
||
Updated•7 years ago
|
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6ca4e646c0
Update Debugger Frontend v14. r=jdescottes.
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8948994 [details] [diff] [review]
rel14.patch
Review of attachment 8948994 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/locales/en-US/debugger.properties
@@ +710,2 @@
> gotoLineModal.placeholder=Go to line…
> +gotoLineModal.key=CmdOrCtrl+;
This change needs a new ID (from https://github.com/devtools-html/debugger.html/pull/4932)
|
|
||
Comment 10•7 years ago
|
||
@Jason
I also see a comment, never addressed, saying to keep using "to" instead of "To". Is that OK?
https://github.com/devtools-html/debugger.html/pull/4932
Flags: needinfo?(jlaster)
|
|
Assignee | |
Comment 11•7 years ago
|
||
thanks flod, it should be fixed here and land in the next release later today
https://github.com/devtools-html/debugger.html/pull/5360/files
Flags: needinfo?(jlaster)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•