Closed Bug 1436210 Opened 2 years ago Closed 2 years ago

Update Debugger Frontend v14

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Attached patch rel14.patchSplinter Review
Attachment #8948994 - Flags: review?(jdescottes)
Comment on attachment 8948994 [details] [diff] [review]
rel14.patch

Review of attachment 8948994 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Talos at https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=d28a38736517c98deda5657e22899b9901a714aa
Attachment #8948994 - Flags: review?(jdescottes) → review+
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6ca4e646c0
Update Debugger Frontend v14. r=jdescottes.
https://hg.mozilla.org/mozilla-central/rev/6d6ca4e646c0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Comment on attachment 8948994 [details] [diff] [review]
rel14.patch

Review of attachment 8948994 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/locales/en-US/debugger.properties
@@ +710,2 @@
>  gotoLineModal.placeholder=Go to line…
> +gotoLineModal.key=CmdOrCtrl+;

This change needs a new ID (from https://github.com/devtools-html/debugger.html/pull/4932)
@Jason
I also see a comment, never addressed, saying to keep using "to" instead of "To". Is that OK?

https://github.com/devtools-html/debugger.html/pull/4932
Flags: needinfo?(jlaster)
thanks flod, it should be fixed here and land in the next release later today
https://github.com/devtools-html/debugger.html/pull/5360/files
Flags: needinfo?(jlaster)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.