Closed
Bug 1436265
Opened 3 years ago
Closed 3 years ago
WebRenderLayerManager does not track ClearType setting on Windows
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
1.79 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
This is just a copy of WR issue https://github.com/servo/webrender/issues/2377 Essentially, if you disable ClearType, WebRender never tracks this. This is because in ClientLayerManage, we normally call gfxDWriteFont::UpdateClearTypeUsage() to update this setting so that it can be queried (see https://dxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientLayerManager.cpp#324) In WebRenderLayerManager we never do this, so it always shows up as enabled when we query the value. Here's a patch that adds a similar call in WebRenderLayerManager that fixes that.
Attachment #8948888 -
Flags: review?(jmuizelaar)
|
||
Updated•3 years ago
|
Blocks: stage-wr-nightly
Attachment #8948888 -
Flags: review?(jmuizelaar) → review+
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5b5d0df3b6ee update ClearType usage in WebRenderLayerManager. r=jrmuizel
|
||
Comment 2•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5b5d0df3b6ee
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
This being fixed with a PR - is there a Gecko side reftest that we can add that catches this problem?
You need to log in
before you can comment on or make changes to this bug.
Description
•