1436403 - Set channels in Rust SDP Parser rather than in RsdparsaSdpAttributeList

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Dan Minor [:dminor]]

At the moment, we're setting the channels in RsdparsaSdpAttributeList::LoadRtpmap if mVideo is true. It would make sense to handle this in the Rust parser itself.

Comment 1

[Johannes Willbold]

Attachment: Bug 1436403: Setting rtpmap channels in rust.

Remvoed the code setting the channels for an rtpmap attribute in the C++ glue code.
Added Rust code that accounts the data in SdpMedia accordingly for rtpmap.

Review commit: https://reviewboard.mozilla.org/r/252872/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252872/

Comment 2

[Dan Minor [:dminor]]

Comment on attachment 8987640 [details]
Bug 1436403: Setting rtpmap channels in rust.

https://reviewboard.mozilla.org/r/252872/#review259632

::: commit-message-6e8e8:3
(Diff revision 1)
> +Bug 1436403: Setting rtpmap channels in rust. r=dminor
> +
> +Remvoed the code setting the channels for an rtpmap attribute in the C++ glue code.

typo: s/Remvoed/Removed/

Comment 3

[Johannes Willbold]

Comment on attachment 8987640 [details]
Bug 1436403: Setting rtpmap channels in rust.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252872/diff/1-2/

Comment 4

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b3f08f78dfc32b71d7ebccec86c3b0251ada280a -d 803ff4b978c4: rebasing 470347:b3f08f78dfc3 "Bug 1436403: Setting rtpmap channels in rust. r=dminor" (tip)
merging media/webrtc/signaling/src/sdp/RsdparsaSdpAttributeList.cpp
merging media/webrtc/signaling/src/sdp/rsdparsa/src/media_type.rs
warning: conflicts while merging media/webrtc/signaling/src/sdp/rsdparsa/src/media_type.rs! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

[Johannes Willbold]

Comment on attachment 8987640 [details]
Bug 1436403: Setting rtpmap channels in rust.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252872/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d498f51af225
Setting rtpmap channels in rust. r=dminor

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d498f51af225