1436590 - Gloda bar chart not working - Gloda produces heaps of errors in the error console

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1436290 +++

While working on bug 1436290 I noticed that Gloda search produces heaps of errors in the error console, already at 59.0a1 (2018-01-19) (64-bit).

pv is not defined  glodaFacetVis.js:62
TypeError: this.hotBars is undefined glodaFacetVis.js:336:5
TypeError: this.hotBars is undefined glodaFacetVis.js:336:5
ReferenceError: pv is not defined glodaFacetVis.js:62:9
TypeError: this.emptyBins is undefined glodaFacetVis.js:326:9
and more.

STR:
Use global search to look for something that will yield a result.
Open the error console.
Hover the mouse over the items in the result page.

Alice, can you please help us to find the regression.

Comment 1

[Alice0775 White]

regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=c470737be118e33d1caf76c2d12d7864e4ced8a8&tochange=aea8da53babbd550b0c61d37555dc868f785dd82
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e4de69553e3faf8136eb9bb7f2f741e1b7e6f866&tochange=d5f42a23909eb181274731b07e4984bfbd18557d

Comment 2

[Jorg K (CEST = GMT+2)]

I have the impression that this is all a consequence of |pv is not defined glodaFacetVis.js:62|.

Looks like the bar chart is done with
https://dxr.mozilla.org/comm-central/source/mail/base/content/protovis-r2.6-modded.js
and 'pv' is the main variable in that file.

I can't see how this hangs together.

Comment 3

[:aceman]

Copied 3rd party libraries that only wait for being broken by the JS engine changes in Gecko.
There is a bug for replacing protovis. Of course it would need to rewrite some of our code that uses it.

Comment 4

[Jorg K (CEST = GMT+2)]

Aceman, looks like you've already found the bug I wanted you to look at.

Andrew, could you please take a look at the M-C regression range in comment #1 and see whether anything catches your eye. Any other hint you might have would be appreciated.

Comment 5

[Alice0775 White]

Triggered by: Bug 1428745


Removing ";version=1.8" from <script> tag in [1]  will fix the error.

[1]
mail/base/content/glodaFacetView.xhtml

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, Alice!! I saw that bug and was looking for a version tag but missed the Xhtml file :-(

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1436590-version-removal.patch

Four left in the tree, one in suite. Killing them all.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36b19d54366f
remove remaining ';version=1.8' from xhtml and xul files (since it's not supported after bug 1428745). rs=bustage-fix

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8949546 [details] [diff] [review]
1436590-version-removal.patch

[Triage Comment]

Comment 10

[:aceman]

Comment on attachment 8949546 [details] [diff] [review]
1436590-version-removal.patch

Review of attachment 8949546 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't seen any ill effects from the errors, but the patch does remove those errors.
Thanks.

I think we intentionally left those version=1.8 for the external library as it may be version 1.8 JS. But if it is no longer accepted by JS engine we have to remove the version and fix the library as needed.

Comment 11

[Jorg K (CEST = GMT+2)]

Beta (TB 59):
https://hg.mozilla.org/releases/comm-beta/rev/5a726658d77047cd54a98568c480be4be18f099f

Comment 12

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8949546 [details] [diff] [review]
1436590-version-removal.patch

Sorry late to game. Thanks+++