1436636 - Clients engine not tracking changes

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Edouard Oger [:eoger]]

For Reasons™, the Clients engine is not registered with the engineManager and never ends up tracking changes because of [0].

[0] https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/services/sync/modules/service.js#468

Patch to follow.

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1436636 - Properly start/stop clients engine tracker.

Review commit: https://reviewboard.mozilla.org/r/218632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218632/

Comment 2

[Edouard Oger [:eoger]]

Comment on attachment 8949271 [details]
Bug 1436636 - Properly start/stop clients engine tracker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218632/diff/1-2/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8949271 [details]
Bug 1436636 - Properly start/stop clients engine tracker.

https://reviewboard.mozilla.org/r/218632/#review224432

Thanks!

::: services/sync/modules/service.js:464
(Diff revision 2)
>        Svc.Prefs.set("engineStatusChanged." + engine, true);
>      }
>    },
>  
> -  async _startTracking() {
> -    const engines = this.engineManager.getAll();
> +  _startTracking() {
> +    const engines = [this.clientsEngine].concat(this.engineManager.getAll());

I think you could use the spread operator here?

`[this.clientsEngine, ...this.engineManager.getAll()];`

(Not that I really care :)

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8949271 [details]
Bug 1436636 - Properly start/stop clients engine tracker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218632/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6843800cfc7
Properly start/stop clients engine tracker. r=markh

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c6843800cfc7