Closed Bug 1436636 Opened 3 years ago Closed 3 years ago

Clients engine not tracking changes

Categories

(Firefox :: Sync, defect, P1)

Product:
Firefox
Component:
Sync
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file)

Bug 1436636 - Properly start/stop clients engine tracker.
59 bytes, text/x-review-board-request
markh
: review+
Details 
For Reasons™, the Clients engine is not registered with the engineManager and never ends up tracking changes because of [0].

[0] https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/services/sync/modules/service.js#468

Patch to follow.
Comment on attachment 8949271 [details]
Bug 1436636 - Properly start/stop clients engine tracker.

https://reviewboard.mozilla.org/r/218632/#review224432

Thanks!

::: services/sync/modules/service.js:464
(Diff revision 2)
>        Svc.Prefs.set("engineStatusChanged." + engine, true);
>      }
>    },
>  
> -  async _startTracking() {
> -    const engines = this.engineManager.getAll();
> +  _startTracking() {
> +    const engines = [this.clientsEngine].concat(this.engineManager.getAll());

I think you could use the spread operator here?

`[this.clientsEngine, ...this.engineManager.getAll()];`

(Not that I really care :)
Attachment #8949271 - Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6843800cfc7
Properly start/stop clients engine tracker. r=markh
https://hg.mozilla.org/mozilla-central/rev/c6843800cfc7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.