Closed Bug 1436637 Opened 2 years ago Closed 2 years ago
Sync might end up in a deadlock
59 bytes, text/x-review-board-request
In Service#observe(), we are awaiting on sync() to finish . In Service#sync(), we are awaiting on observe() to finish . You can see the problem: if we receive two push notifications at the same time that notify of "sync:collection_changed", we might end up in a deadlock and sync will not work until Firefox is restarted.  https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/services/sync/modules/service.js#432  https://searchfox.org/mozilla-central/rev/84cea84b12145d752e50ddca6be5462c38510e35/services/sync/modules/service.js#1102 Patch to follow.
Comment on attachment 8949273 [details] Bug 1436637 - Revert back to a sync observer in Service. https://reviewboard.mozilla.org/r/218636/#review224438 Awesome, thanks!
Attachment #8949273 - Flags: review?(markh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/7cbfec3bb94e Revert back to a sync observer in Service. r=markh
You need to log in before you can comment on or make changes to this bug.