Closed Bug 1436642 Opened 4 years ago Closed 4 years ago

With runByManifest, dom/animation/test/chrome/test_animation_performance_warning.html fails

Categories

(Testing :: Mochitest, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: gbrown, Assigned: hiro)

References

Details

Attachments

(1 file)

In bug 1393326 we are trying to run Android mochitests, including mochitest-chrome, by-manifest, meaning that each manifest of tests is run in a separate browser instance.

When we run mochitest-chrome by manifest, there is a single new test failure, in dom/animation/test/chrome/test_animation_performance_warning.html, on both Android 4.3 API16+ opt and Android 4.3 API16+ debug; it runs and passes on Android x86.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fded1dca347246a9ca659b38c2e0e32108d9155
We are setting a pref value in the test [1].  If the pref was set in chrome.ini, what happens?

[1] https://hg.mozilla.org/mozilla-central/file/8cc2427a322c/dom/animation/test/chrome/test_animation_performance_warning.html#l41
Thanks :hiro, but I don't think it is possible to set a pref in chrome.ini (prefs can only be set in reftest manifests, I think).
Actually, it is possible. But it can only be set in the DEFAULT section, and if the manifest gets used when --run-by-manifest is off, then the harness will error out. (So if it's a shared manifest between android and desktop, the android run will fail as run-by-manifest isn't turned on there yet).

E.g:
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/performance/browser.ini#7
Oh, right, that's why I'm doing this run-by-manifest-on-android work anyway! How silly!
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> We are setting a pref value in the test [1].  If the pref was set in
> chrome.ini, what happens?
> 
> [1]
> https://hg.mozilla.org/mozilla-central/file/8cc2427a322c/dom/animation/test/
> chrome/test_animation_performance_warning.html#l41

The test still fails if the pref is set in chrome.ini:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=56169000bb949d45519893c73cf6653e25e6489b
Thanks Geoff, I will take a look.
Flags: needinfo?(hikezoe)
I could confirm the failure on local emulator when I run "./mach mochitest dom/animation/test/chrome", so I'd say the test has been broken in the first place.  I don't quite understand why the width value which is used in the failure case has been changed and why 5200px was chosen in bug 1364221 .

CCing Jared and keep NI to me.
I think the value, 5200px, was too small for Android arm emulator.  (The scale value on the emulator is 0.5x?)

Using 10000px for the area test and using 20000px for the other case work fine;

https://treeherder.mozilla.org/#/jobs?repo=try&revision=162b3df18b892de9bdc29d1f42ea50a257b70600
Flags: needinfo?(hikezoe)
Comment on attachment 8949871 [details]
Bug 1436642 - Make target element size larger to be unable to send transform animations to the compositor.

https://reviewboard.mozilla.org/r/219194/#review225026

If I remember right I had to use the lower number because I was getting crashes on Android with larger numbers. Though much may have changed since then so let's try it again :)
Attachment #8949871 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #11)
> Comment on attachment 8949871 [details]
> Bug 1436642 - Make target element size larger to be unable to send transform
> animations to the compositor.
> 
> https://reviewboard.mozilla.org/r/219194/#review225026
> 
> If I remember right I had to use the lower number because I was getting
> crashes on Android with larger numbers. Though much may have changed since
> then so let's try it again :)

Thanks!  Let's see what happens for a while. :)
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5282133fa20
Make target element size larger to be unable to send transform animations to the compositor. r=jaws
https://hg.mozilla.org/mozilla-central/rev/f5282133fa20
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee: gbrown → hikezoe
You need to log in before you can comment on or make changes to this bug.