Closed Bug 1436669 Opened 7 years ago Closed 7 years ago

Fluent 0.5.x syntax should allow leading dot '.' for inline strings.

Categories

(L20n :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: stas)

References

Details

I've tried running Webstatus with compare-locales 2.7.0 (well, master) and python-fluent 0.6.1

We have 3 projects and a few errors showing up. One class of errors is related to leading periods.

https://github.com/mozilla/testpilot/blob/e21e15c386aba1b6909e6dee022dae3debaf79f4/locales/en-US/experiments.ftl#L133

snoozetabsToursteps3Copy = ...Snooze Tabs brings it back!

This is now reported as Junk by compare-locales. From what I understand from stas, it should look like this when serialized back

snoozetabsToursteps3Copy = {"..."}স্নুজ ট্যাব আবার ফিরে আসবে!

Instead of https://github.com/mozilla/testpilot/blob/e21e15c386aba1b6909e6dee022dae3debaf79f4/locales/bn-BD/experiments.ftl#L45

I've thought about fixing all locales in GitHub, but truth is that we don't know if that was just lazy copy and pasting from English, or a stylistic choice, and there's another string before that that uses the same.

There is also an error reported for Arabic
https://github.com/mozilla/testpilot/blob/e21e15c386aba1b6909e6dee022dae3debaf79f4/locales/ar/experiments.ftl#L31

minvidToursteps0Copy = .اختر أيقونة للبدء في استخدام الفيديو الصغير
(In reply to Francesco Lodolo [:flod] from comment #0)
> I've thought about fixing all locales in GitHub, but truth is that we don't
> know if that was just lazy copy and pasting from English, or a stylistic
> choice, and there's another string before that that uses the same.

Uhm, this is really confusing: I meant, there's another string before this one that ends with ... (same characters), so fixing only one (replacing ... with …) doesn't make sense
https://github.com/mozilla/testpilot/blob/e21e15c386aba1b6909e6dee022dae3debaf79f4/locales/en-US/experiments.ftl#L132
We had a conversation in #l20n, and this is actually a fluent bug.

We should allow '.' as first character for inline strings.

Moving over
Component: Pontoon → General
Product: Webtools → L20n
Summary: [FTL] Pontoon should escape leading periods when serializing strings → Fluent 0.5.x syntax should allow leading dot '.' for inline strings.
Version: Trunk → unspecified
Depends on: 1436683
Depends on: 1436685
Blocks: 1432227
Is this fixed at this point?
Good question, we need a rust one of this still, but that doesn't block bug 1432227.
We should mark this as fixed. We don't track rust in Bugzilla and the spec changes are also tracked in Github.
Agreed.
Assignee: nobody → stas
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.