1436676 - Remove the telemetry probe for parallel stylo traversals.

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Just for tracking removing bug 1421195, which was going to be for ~1 nightly.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Manish, just curious, when do you want this to go away? It's not urgent at all, I just saw the code and thought it was worth tracking it.

Comment 2

[Manish Goregaokar [:manishearth]]

We can kill it now

Comment 3

[Mayank Bansal]

Is there any publicly accessible/sharable insights you gained from the telemetry ? I am quite curious to know how stylo performs in the wild

Comment 4

[Manish Goregaokar [:manishearth]]

The basic insight was that a lot of pages don't benefit from parallelism because they have small DOMs, but the ones that do end up using parallelism for almost all the traversals.

It wasn't a direct measurement of performance so it doesn't really give insight on Stylo's performance in the wild; it does give us insight that our heuristics for choosing parallelism are working.

Comment 5

[Mayank Bansal]

Thanks!
One last question: do you plan to modify the heuristics to enable parallelism on some subset of pages with smaller DOM? Or tweak them in some other way?

Comment 6

[Manish Goregaokar [:manishearth]]

No, parallelism doesn't generally get us wins for smaller DOMs even when turned on.

Comment 7

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1436676 - Remove the telemetry probe for parallel stylo traversals ;

Review commit: https://reviewboard.mozilla.org/r/218932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218932/

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8949567 [details]
Bug 1436676 - Remove the telemetry probe for parallel stylo traversals ;

https://reviewboard.mozilla.org/r/218932/#review224692

Thanks!

Comment 9

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]