1436746 - Sent tab is not received when the app is in foreground without performing a sync.

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 11.0 (8861)
Device: iPad Air 2
iOS: 11.2.5

Pre-requisites: 
- Log in to FxA on Desktop and one iOS device

Steps to reproduce:
1. Go to "google.com" on desktop
2. Open Firefox on iOS
3. On desktop, right click on the tab and click "Send tab to Device"  

Actual results:
- The tab is not received when the app is in foreground. Only after performing a sync on iOS the tab will be received. 

Expected results:
- The tab should be received on iOS when the app is in foreground without performing Sync.

Note:
- This is working flawlessly on 10.6. The sent tab is received almost immediately without performing Sync on iOS.

Comment 1

[Catalin Suciu [:csuciu]]

I'm reproducing this issue on an iPad Pro running iOS 10.3.3.
No push notifications are received on iOS when using RC 11.0 (9713). 

The issue is not reproducible on v10.6 (8836).

Comment 2

[Justin D'Arcangelo [:justindarc]]

Can QA re-test this?

Comment 3

[Simon Basca [:SimonB]]

Tested on iPhone X (11.2.6).

This issue is still reproducible on the latest beta 12.0 (10451). The sent tab from desktop to iOS is not received while the app is in foreground. After performing a manual sync, the tab is received.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 5

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8976332 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/38a6e333c8a4080d4c86a6a1cb8d3783db9b7142

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on 12.0 (10757).