1436855 - Crash in mozilla::PresShell::DoFlushPendingNotifications

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is
report bp-b24c9d8a-15c8-41cc-a4a1-393eb0180204.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::PresShell::DoFlushPendingNotifications layout/base/PresShell.cpp:4162
1 libxul.so mozilla::ScrollFrameHelper::AsyncScrollPortEvent::Run layout/generic/nsGfxScrollFrame.cpp:4955
2 libxul.so nsRootPresContext::FlushWillPaintObservers layout/base/nsPresContext.cpp:3526
3 libxul.so mozilla::PresShell::WillPaint layout/base/PresShell.cpp:8526
4 libxul.so nsViewManager::CallWillPaintOnObservers view/nsViewManager.cpp:1138
5 libxul.so nsViewManager::ProcessPendingUpdates view/nsViewManager.cpp:1100
6 libxul.so nsRefreshDriver::Tick layout/base/nsRefreshDriver.cpp:2069
7 libxul.so mozilla::RefreshDriverTimer::TickRefreshDrivers layout/base/nsRefreshDriver.cpp:310
8 libxul.so mozilla::RefreshDriverTimer::Tick layout/base/nsRefreshDriver.cpp:332
9 libxul.so mozilla::VsyncRefreshDriverTimer::RunRefreshDrivers layout/base/nsRefreshDriver.cpp:773

=============================================================

This is hitting a release assert:
  MOZ_RELEASE_ASSERT(mIsDestroying || mDocument->GetShell() == this)

Comment 1

[Andrew McCreight [:mccr8]]

Emilio, are you still looking at these crashes?

Comment 2

[Ted Campbell [:tcampbell]]

I've hit this a number of times this week while on searchfox. Both Win64 and Linux64.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> Emilio, are you still looking at these crashes?

Yes.

(In reply to Ted Campbell [:tcampbell] from comment #2)
> I've hit this a number of times this week while on searchfox. Both Win64 and
> Linux64.

Do you have any more detailed STR? If so, that'd be super-helpful. Thanks!

Comment 4

[Ted Campbell [:tcampbell]]

I unfortunately do not. Generally following links and mouse wheel scrolling. Has been happening once every other day out the the many many hours I've spent on searchfox in the last two weeks. I will keep an eye out and try to take notes the next times.

Comment 5

[Nicholas Nethercote [inactive]]

This is the #1 Android topcrash in Nightly 20180209102731.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1436855: Flush notifications via the document in AsyncScrollPortEvent.

One at a time...

Review commit: https://reviewboard.mozilla.org/r/219390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219390/

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8950122 [details]
Bug 1436855: Flush notifications via the document in AsyncScrollPortEvent.

https://reviewboard.mozilla.org/r/219390/#review225896

r=me

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6447e0e0d81b
Flush notifications via the document in AsyncScrollPortEvent. r=bz

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6447e0e0d81b

Comment 10

[Julian Seward [:jseward]]

This signature is still appearing, in low volume,
in the nightly of 20180222154733.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(In reply to Julian Seward [:jseward] from comment #10)
> This signature is still appearing, in low volume,
> in the nightly of 20180222154733.

Can you file a different bug for that? Let's fix the issues one by one.