1436887 - GeckoView turns on tracking protection for sessions with USE_PRIVATE MODE even though USE_TRACKING_PROTECTION was not specified

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is because Firefox defaults to having TP on for private mode. We want to separate these for GV.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This might be a good reason to have a separate prefs file for GV.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1436887-1.0-Add-dedicated-GeckoView-prefs-file.-.patch

Add a GV pref file (copy of Fennec's mobile.js).

Do we want to split pref maintenance out of Fennec?
Assuming we do, we need to go over each pref to check for validity and eventually move the config out of the Fennec app.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8950311 [details] [diff] [review]
0001-Bug-1436887-1.0-Add-dedicated-GeckoView-prefs-file.-.patch

You might be able to use `#ifdef MOZ_GECKOVIEW_JAR` inside mobile.js. If not, you should still be able to `#include "geckoview-prefs.js"` from mobile.js. In either case, I'd like us to only maintain the diff between GV and Fennec, rather than two separate sets of prefs.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1436887-1.1-Add-GeckoView-prefs-file.-r-snorp-jc.patch

The check for MOZ_GECKOVIEW_JAR in mobile.js fails, but we can conditionally package geckoview-prefs.js and import mobile.js there instead.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8950693 [details] [diff] [review]
0001-Bug-1436887-1.1-Add-GeckoView-prefs-file.-r-snorp-jc.patch

Review of attachment 8950693 [details] [diff] [review]:
-----------------------------------------------------------------

I think I slightly prefer "mobile.js" including "geckoview-prefs.js" (because Fennec is built on top of GeckoView), but it's not a big deal.

Comment 6

[Eugen Sawin [:esawin]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #5)
> I think I slightly prefer "mobile.js" including "geckoview-prefs.js"
> (because Fennec is built on top of GeckoView), but it's not a big deal.

Is there a way to conditionally import it there without MOZ_GECKOVIEW_JAR defined?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd1395b937e
[1.1] Add GeckoView prefs file. r=snorp,jchen

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9dd1395b937e