Closed Bug 1436887 Opened 3 years ago Closed 3 years ago
View turns on tracking protection for sessions with USE _PRIVATE MODE even though USE _TRACKING _PROTECTION was not specified
This is because Firefox defaults to having TP on for private mode. We want to separate these for GV.
3 years ago
Assignee: nobody → esawin
This might be a good reason to have a separate prefs file for GV.
Add a GV pref file (copy of Fennec's mobile.js). Do we want to split pref maintenance out of Fennec? Assuming we do, we need to go over each pref to check for validity and eventually move the config out of the Fennec app.
Attachment #8950311 - Flags: review?(snorp)
3 years ago
Attachment #8950311 - Flags: review?(snorp) → review+
Comment on attachment 8950311 [details] [diff] [review] 0001-Bug-1436887-1.0-Add-dedicated-GeckoView-prefs-file.-.patch You might be able to use `#ifdef MOZ_GECKOVIEW_JAR` inside mobile.js. If not, you should still be able to `#include "geckoview-prefs.js"` from mobile.js. In either case, I'd like us to only maintain the diff between GV and Fennec, rather than two separate sets of prefs.
Attachment #8950311 - Flags: review?(nchen) → feedback+
The check for MOZ_GECKOVIEW_JAR in mobile.js fails, but we can conditionally package geckoview-prefs.js and import mobile.js there instead.
Comment on attachment 8950693 [details] [diff] [review] 0001-Bug-1436887-1.1-Add-GeckoView-prefs-file.-r-snorp-jc.patch Review of attachment 8950693 [details] [diff] [review]: ----------------------------------------------------------------- I think I slightly prefer "mobile.js" including "geckoview-prefs.js" (because Fennec is built on top of GeckoView), but it's not a big deal.
Attachment #8950693 - Flags: review?(nchen) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd1395b937e [1.1] Add GeckoView prefs file. r=snorp,jchen
You need to log in before you can comment on or make changes to this bug.