Closed Bug 1436887 Opened 3 years ago Closed 3 years ago

GeckoView turns on tracking protection for sessions with USE_PRIVATE MODE even though USE_TRACKING_PROTECTION was not specified

Categories

(GeckoView :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: snorp, Assigned: esawin)

Details

Attachments

(1 file, 1 obsolete file)

This is because Firefox defaults to having TP on for private mode. We want to separate these for GV.
Assignee: nobody → esawin
This might be a good reason to have a separate prefs file for GV.
Add a GV pref file (copy of Fennec's mobile.js).

Do we want to split pref maintenance out of Fennec?
Assuming we do, we need to go over each pref to check for validity and eventually move the config out of the Fennec app.
Attachment #8950311 - Flags: review?(snorp)
Attachment #8950311 - Flags: review?(snorp) → review+
Attachment #8950311 - Flags: review?(nchen)
Comment on attachment 8950311 [details] [diff] [review]
0001-Bug-1436887-1.0-Add-dedicated-GeckoView-prefs-file.-.patch

You might be able to use `#ifdef MOZ_GECKOVIEW_JAR` inside mobile.js. If not, you should still be able to `#include "geckoview-prefs.js"` from mobile.js. In either case, I'd like us to only maintain the diff between GV and Fennec, rather than two separate sets of prefs.
Attachment #8950311 - Flags: review?(nchen) → feedback+
The check for MOZ_GECKOVIEW_JAR in mobile.js fails, but we can conditionally package geckoview-prefs.js and import mobile.js there instead.
Attachment #8950311 - Attachment is obsolete: true
Attachment #8950693 - Flags: review?(nchen)
Comment on attachment 8950693 [details] [diff] [review]
0001-Bug-1436887-1.1-Add-GeckoView-prefs-file.-r-snorp-jc.patch

Review of attachment 8950693 [details] [diff] [review]:
-----------------------------------------------------------------

I think I slightly prefer "mobile.js" including "geckoview-prefs.js" (because Fennec is built on top of GeckoView), but it's not a big deal.
Attachment #8950693 - Flags: review?(nchen) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dd1395b937e
[1.1] Add GeckoView prefs file. r=snorp,jchen
https://hg.mozilla.org/mozilla-central/rev/9dd1395b937e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 60 → mozilla60
You need to log in before you can comment on or make changes to this bug.