Refactor partial profile storage and move UniqueStacks into something that's only allocated on demand

RESOLVED FIXED in Firefox 60

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The lifetime of mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers is a little hard to understand at the moment.

I'm going to attach a patch which should make the code easier to understand, and which addresses part of bug 1436179.

It does not address bug 1434965, but it should make fixing that bug more straightforward.

Comment 2

a year ago
mozreview-review
Comment on attachment 8949639 [details]
Bug 1436924 - Group mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers into a PartialThreadProfile struct that's heap-allocated on demand.

https://reviewboard.mozilla.org/r/218994/#review224982
Attachment #8949639 - Flags: review?(n.nethercote) → review+

Comment 3

a year ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/346018e93a21
Group mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers into a PartialThreadProfile struct that's heap-allocated on demand. r=njn

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/346018e93a21
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.