Closed Bug 1436924 Opened 2 years ago Closed 2 years ago

Refactor partial profile storage and move UniqueStacks into something that's only allocated on demand

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

The lifetime of mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers is a little hard to understand at the moment.

I'm going to attach a patch which should make the code easier to understand, and which addresses part of bug 1436179.

It does not address bug 1434965, but it should make fixing that bug more straightforward.
Comment on attachment 8949639 [details]
Bug 1436924 - Group mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers into a PartialThreadProfile struct that's heap-allocated on demand.

https://reviewboard.mozilla.org/r/218994/#review224982
Attachment #8949639 - Flags: review?(n.nethercote) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/346018e93a21
Group mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers into a PartialThreadProfile struct that's heap-allocated on demand. r=njn
https://hg.mozilla.org/mozilla-central/rev/346018e93a21
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.