1436961 - Remove unused XPCOMUtils.jsm imports after bug 1431533 (from accessible/jsat/ files)

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Bug 1431533 replaced XPCOMUtils.defineLazyModuleGetter with ChromeUtils.defineModuleGetter but left behind unused XPCOMUtils.jsm imports, for instance:

https://hg.mozilla.org/mozilla-central/rev/e6a7b5e11ba856ee3535f76c6bcca17ea29e3d5f#l324.10

Comment 1

[Nabeel Ahsen]

Hi there, I'm kind of new here. I'd like to work on this bug, would I be able to get some pointers to the right files?

Comment 2

[Dão Gottwald [:dao]]

(In reply to nabeel.ahsen from comment #1)
> Hi there, I'm kind of new here. I'd like to work on this bug, would I be
> able to get some pointers to the right files?

It's a bit of a hassle. Basically you need to look for any XPCOMUtils.jsm import:

https://searchfox.org/mozilla-central/search?q=XPCOMUtils.jsm&case=true&path=

Open any of these files and check if XPCOMUtils is used there. If it isn't, the XPCOMUtils.jsm import should probably be removed.

Since there are almost a thousand XPCOMUtils.jsm imports, you could also just focus on a subset of files. No need to fix them all at once.

Comment 3

[Nabeel Ahsen]

Attachment: Removing unnecessary XPCOMUtils.jsm imports from accessible/jsat/ files

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8957958 [details] [diff] [review]
Removing unnecessary XPCOMUtils.jsm imports from accessible/jsat/ files

Looks good, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8f652436838
Remove obsolete XPCOMUtils.jsm imports in accessible/jsat/. r=dao

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a8f652436838

Comment 7

[Mark Banner (:standard8)]

The rest of this is going to be fixed by bug 1478305 & friends by improving our ESLint support. Lets change the scope of this one and call it fixed as we did land a patch here.