1437052 - Focused item in menu bar has incorrect highlight color with a high-contrast theme set in Windows

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Kostadin Kolev]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180206200532

Steps to reproduce:

1. From Windows 10 Settings -> Ease of Access -> Color & High-Contrast, choose the high-contrast black theme and click "Apply" there to apply it to the system.
2. Open Firefox.
3. Press ALT key to move the focus to the menu bar.
4. Use the left and right arrow keys to move the focus between the items in the menu bar.


Actual results:

The background/highlight color of the selected/focused item has black color and the text is also black, making it unreadable.


Expected results:

The background/highlight color should be light blue/cyan that is used for menu highlighting in the used high-contrast black theme in Windows. The text color is correct - it should be black as it is.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1437052 - Consolidate #main-menubar > menu appearance and color rules.

Review commit: https://reviewboard.mozilla.org/r/246090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246090/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8979888 [details]
Bug 1437052 - Consolidate #main-menubar > menu appearance and color rules.

https://reviewboard.mozilla.org/r/246090/#review253380

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b015b36a001c
Consolidate #main-menubar > menu appearance and color rules. r=Felipe

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b015b36a001c

Comment 6

[MarkRH]

Looks like this broke how the menus look in Windows 7 Pro (Classic Theme).  Did a Mozregression and it pointed to this.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=238eb0ed2874eac59df57722b507b1bc0b6652e0&tochange=f605d6efe3476538613b0fcca7d2582c2a3606cc

2018-06-13T04:47:08: DEBUG : Found commit message:
Bug 1437052 - Consolidate #main-menubar > menu appearance and color rules. r=Felipe

MozReview-Commit-ID: 7RicXHVrbEQ

2018-06-13T04:47:08: INFO : The bisection is done.
2018-06-13T04:47:08: INFO : Stopped

Looks like this to me: https://i.imgur.com/XB6SI8a.png

Comment 7

[Dão Gottwald [:dao]]

MarkRH, would you mind filing a new bug on this? Thanks!

Comment 8

[MarkRH]

Alright, I made a bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1468645

Couldn't see a way to choose the Nightly version.