Closed
Bug 1437055
Opened 6 years ago
Closed 6 years ago
Enable some debugger tests
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
Details
Attachments
(1 file, 3 obsolete files)
|
5.32 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8949766 -
Flags: review?(jdescottes)
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c667044750ad5dce22ae4f447de87e24ac0cc745
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8949766 [details] [diff] [review] r16-1.patch Review of attachment 8949766 [details] [diff] [review]: ----------------------------------------------------------------- Clearing the review flag, this doesn't seem ready for review. Some tests seem to be renamed in browser.ini (browser_dbg_keyboard_shortcuts.js -> browser_dbg-keyboard-shortcuts.js) but no actual file move in the patch.
Attachment #8949766 -
Flags: review?(jdescottes)
|
|
||
Comment 4•6 years ago
|
||
Ah sorry the files have been renamed, it's just that splinter doesn't show them for some reason. Looking at try devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js fails on several platforms.
|
|
Assignee | |
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bf6bde273a796c6bc94abf5a134e4a96383b012 ^ new try run... w/ this fix: https://github.com/devtools-html/debugger.html/pull/5397
|
|
Assignee | |
Comment 6•6 years ago
|
||
alright, the try run is green sans-windows for quick open which i'll disable in the next patch.
|
|
Assignee | |
Comment 7•6 years ago
|
||
Attachment #8949766 -
Attachment is obsolete: true
Attachment #8950573 -
Flags: review?(jdescottes)
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 8950573 [details] [diff] [review] r16-2.patch Review of attachment 8950573 [details] [diff] [review]: ----------------------------------------------------------------- Is there another patch with a bundle update? This doesn't look like a debugger release. If that's really Release 16.0, we should still: - update the README accordingly - create a release branch on GH Otherwise I'm fine with landing this as a "test fix" and not make it a release. In that case, can you update the commit message to something else?
Attachment #8950573 -
Flags: review?(jdescottes)
|
|
Assignee | |
Comment 9•6 years ago
|
||
Attachment #8950630 -
Flags: review?(jdescottes)
|
|
Assignee | |
Comment 10•6 years ago
|
||
Attachment #8950573 -
Attachment is obsolete: true
Attachment #8950630 -
Attachment is obsolete: true
Attachment #8950630 -
Flags: review?(jdescottes)
Attachment #8950631 -
Flags: review?(jdescottes)
|
|
||
Comment 11•6 years ago
|
||
Comment on attachment 8950631 [details] [diff] [review] r16-3.patch Review of attachment 8950631 [details] [diff] [review]: ----------------------------------------------------------------- Looks good Jason, thanks for working on those tests! (nb: In case you want to do the release 16 in another bug, can you rename the bug and unblock the meta?)
Attachment #8950631 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: checkin-needed
|
|
Assignee | |
Updated•6 years ago
|
Summary: Update Debugger Frontend v16 → Enable some debugger tests
|
|
||
Updated•6 years ago
|
No longer blocks: debugger-bundle-updates
|
|
||
Updated•6 years ago
|
Whiteboard: checkin-needed
|
||
Comment 12•6 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f699c4a7fa05 Re-enable some debugger mochitests. r=jdescottes
|
||
Comment 13•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f699c4a7fa05
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•