Closed Bug 1437055 Opened 7 years ago Closed 7 years ago

Enable some debugger tests

Categories

(DevTools :: Debugger, enhancement, P3)

Product:
DevTools
Component:
Debugger
Type:
enhancement

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 3 obsolete files)

r16-3.patch
5.32 KB, patch
jdescottes
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch r16-1.patch (obsolete) — — Splinter Review
Attachment #8949766 - Flags: review?(jdescottes)
Comment on attachment 8949766 [details] [diff] [review] r16-1.patch Review of attachment 8949766 [details] [diff] [review]: ----------------------------------------------------------------- Clearing the review flag, this doesn't seem ready for review. Some tests seem to be renamed in browser.ini (browser_dbg_keyboard_shortcuts.js -> browser_dbg-keyboard-shortcuts.js) but no actual file move in the patch.
Attachment #8949766 - Flags: review?(jdescottes)
Ah sorry the files have been renamed, it's just that splinter doesn't show them for some reason. Looking at try devtools/client/debugger/new/test/mochitest/browser_dbg-quick-open.js fails on several platforms.
alright, the try run is green sans-windows for quick open which i'll disable in the next patch.
Attached patch r16-2.patch (obsolete) — — Splinter Review
Attachment #8949766 - Attachment is obsolete: true
Attachment #8950573 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Blocks: debugger-bundle-updates
Priority: -- → P3
Comment on attachment 8950573 [details] [diff] [review] r16-2.patch Review of attachment 8950573 [details] [diff] [review]: ----------------------------------------------------------------- Is there another patch with a bundle update? This doesn't look like a debugger release. If that's really Release 16.0, we should still: - update the README accordingly - create a release branch on GH Otherwise I'm fine with landing this as a "test fix" and not make it a release. In that case, can you update the commit message to something else?
Attachment #8950573 - Flags: review?(jdescottes)
Attached patch r16-3.patch (obsolete) — — Splinter Review
Attachment #8950630 - Flags: review?(jdescottes)
Attached patch r16-3.patch — — Splinter Review
Attachment #8950573 - Attachment is obsolete: true
Attachment #8950630 - Attachment is obsolete: true
Attachment #8950630 - Flags: review?(jdescottes)
Attachment #8950631 - Flags: review?(jdescottes)
Comment on attachment 8950631 [details] [diff] [review] r16-3.patch Review of attachment 8950631 [details] [diff] [review]: ----------------------------------------------------------------- Looks good Jason, thanks for working on those tests! (nb: In case you want to do the release 16 in another bug, can you rename the bug and unblock the meta?)
Attachment #8950631 - Flags: review?(jdescottes) → review+
Whiteboard: checkin-needed
Summary: Update Debugger Frontend v16 → Enable some debugger tests
Whiteboard: checkin-needed
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f699c4a7fa05 Re-enable some debugger mochitests. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/f699c4a7fa05
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: