1437118 - Crash in GetPrincipalURIFromNode

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-18ba440e-1ef6-43f0-ab88-898670180209.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll GetPrincipalURIFromNode widget/nsDragServiceProxy.cpp:48
1 xul.dll nsDragServiceProxy::InvokeDragSessionImpl widget/nsDragServiceProxy.cpp:68
2 xul.dll nsBaseDragService::InvokeDragSession widget/nsBaseDragService.cpp:247
3 xul.dll nsBaseDragService::InvokeDragSessionWithImage widget/nsBaseDragService.cpp:285
4 xul.dll mozilla::EventStateManager::DoDefaultDragStart dom/events/EventStateManager.cpp:2147
5 xul.dll mozilla::EventStateManager::GenerateDragGesture dom/events/EventStateManager.cpp:1936
6 xul.dll mozilla::EventStateManager::PreHandleEvent dom/events/EventStateManager.cpp:724
7 xul.dll mozilla::PresShell::HandleEventInternal layout/base/PresShell.cpp:7759
8 xul.dll mozilla::PresShell::HandleEventWithTarget layout/base/PresShell.cpp:7580
9 xul.dll mozilla::PointerEventHandler::DispatchPointerFromMouseOrTouch dom/events/PointerEventHandler.cpp:532

=============================================================

There is 1 crash in nightly 60 with buildid 20180209102946. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1424107.

[1] https://hg.mozilla.org/mozilla-central/rev?node=fc5cbc7e0d7f

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Null-check principalURI returned by URI getter.

Apparently GetURI may return null in successful case.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8949942 [details] [diff] [review]
Null-check principalURI returned by URI getter.

Review of attachment 8949942 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b206e4fb63ec6f38439d405955b20398faf27ea0
Bug 1437118 - Null-check principalURI returned by URI getter. r=froydnj

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b206e4fb63ec