1437226 - Fix test disable linter message

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Disabled mochitest linter message says to use "disable =". This should be "disabled =".

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1437226 - Fix text-disable linter message;

Review commit: https://reviewboard.mozilla.org/r/219230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219230/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8949927 [details]
Bug 1437226 - Fix text-disable linter message;

https://reviewboard.mozilla.org/r/219230/#review224996

Oops, thanks for catching this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50705220c972
Fix text-disable linter message; r=ahal

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing for failing linting opt at tools/lint/test-disable.yml:3:81

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=50705220c972c17516eba90f49b37969318bbd23

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=161488716&repo=autoland&lineNumber=240

Backout: https://hg.mozilla.org/integration/autoland/rev/d3718f3707373d34c548e79ba1ec123d27ed579d

Comment 5

[Andrew Halberstadt [:ahal]]

Ugh, that's annoying.

The fact that yamllint didn't run on mozreview is a known issue (there's a github issue somewhere that I can't find right now). I also talked to Callek and he isn't opposed to bumping the max line length up to 100.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

I just fixed it by using the Broken Line operator (>). It's back on try now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=832cf4dd56670f105fe7a59fae19f70e4746cbce

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Er, I meant "Folded Line operator" there. It'll just take the newline and indentation on the next line and turn it into a single space, so it should come out fine.

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

And the linter battle continues on try, as I accidentally left a space at the end of a line. https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd56761e05f25e6a77dc34a0ae1ccb28151e3e56

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e14bc2ba524
Fix text-disable linter message; r=ahal

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1e14bc2ba524