1437244 - Try to assert more about when we have current styles.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

I'd like to restrict stylist updating to known points, in order for it to be more performant.

Let's try to assert and justify why we don't need to update it at a couple places.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Huh, I thought I had posted a patch here :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1437244: Try to assert a bit more about stylist accesses.

The keyframe stuff runs from animation building, which needs clean styles
already.

Same for counter styles, they run from a well-defined point in time where rules
should be up-to-date already.

The canvas stuff needs no stylist access mostly, since it's only used to compute
a couple font-related things.

Review commit: https://reviewboard.mozilla.org/r/219802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219802/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8950523 [details]
Bug 1437244: Try to assert a bit more about stylist accesses.

https://reviewboard.mozilla.org/r/219802/#review225532

To be honest I don't quite understand the comment about @keyframes in Shadow DOM, but all changes make sense to me.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8950523 [details]
Bug 1437244: Try to assert a bit more about stylist accesses.

https://reviewboard.mozilla.org/r/219802/#review225532

It's unclear what a `@keyframes` rule means in Shadow DOM, and whether it should apply. But other browsers do animate using the keyframes in those, so we may need to look into them.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1393a9de14bd
Try to assert a bit more about stylist accesses. r=hiro

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1393a9de14bd