Closed Bug 1437244 Opened 2 years ago Closed 2 years ago

Try to assert more about when we have current styles.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

I'd like to restrict stylist updating to known points, in order for it to be more performant.

Let's try to assert and justify why we don't need to update it at a couple places.
Huh, I thought I had posted a patch here :)
Comment on attachment 8950523 [details]
Bug 1437244: Try to assert a bit more about stylist accesses.

https://reviewboard.mozilla.org/r/219802/#review225532

To be honest I don't quite understand the comment about @keyframes in Shadow DOM, but all changes make sense to me.
Attachment #8950523 - Flags: review?(hikezoe) → review+
Comment on attachment 8950523 [details]
Bug 1437244: Try to assert a bit more about stylist accesses.

https://reviewboard.mozilla.org/r/219802/#review225532

It's unclear what a `@keyframes` rule means in Shadow DOM, and whether it should apply. But other browsers do animate using the keyframes in those, so we may need to look into them.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1393a9de14bd
Try to assert a bit more about stylist accesses. r=hiro
https://hg.mozilla.org/mozilla-central/rev/1393a9de14bd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.