Closed Bug 1437247 Opened 7 years ago Closed 8 months ago

Remove workaround to forcibly construct binding in browser/components/preferences/in-content/subdialogs.js once browser binding is removed

Categories

(Core :: XBL, task, P5)

Product:
Core
Component:
XBL
Platform:
Desktop
All
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox60 --- affected

People

(Reporter: arai, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fixed in bug 1873068])

In bug 1431960 patch I added a code to forcibly construct frame to load browser binding, in SubDialog.prototype.open @ browser/components/preferences/in-content/subdialogs.js Once browser binding got removed, this workaround should also be removed.
Hi :arai, did you put a TODO into the patch itself pointing to this bug? I saw there was some implementation of _open() in there, but not exactly SubDialog.prototype.open?
Flags: needinfo?(arai.unmht)
Priority: -- → P5
Summary: Remove workaround to forcibly construct binding in browser/components/preferences/in-content/subdialogs.js → Remove workaround to forcibly construct binding in browser/components/preferences/in-content/subdialogs.js once browser binding is removed

This should be fixable now that <browser> is a Custom Element (Bug 1441935).

Depends on: 1441935
Type: enhancement → task
Severity: normal → S3

I removed this code in bug 1873068.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → RESOLVED
Closed: 8 months ago
Depends on: 1873068
OS: Unspecified → All
Hardware: Unspecified → Desktop
Resolution: --- → FIXED
Whiteboard: [fixed in bug 1873068]
You need to log in before you can comment on or make changes to this bug.