Closed
Bug 1437255
Opened 6 years ago
Closed 6 years ago
@@unscopable value objects in the DOM should have a null prototype
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
118.44 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 9YjnPHe78Tg
Attachment #8949955 -
Flags: review?(kyle)
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: 9YjnPHe78Tg
Attachment #8949965 -
Flags: review?(kyle)
Assignee | ||
Updated•6 years ago
|
Attachment #8949955 -
Attachment is obsolete: true
Attachment #8949955 -
Flags: review?(kyle)
Updated•6 years ago
|
Attachment #8949965 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a6088a5f48ee Use a null prototype for @@unscopables objects in the DOM. r=qdot
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/9490 for changes under testing/web-platform/tests
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a6088a5f48ee
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Can't merge web-platform-tests PR due to failing upstream tests
Can't merge web-platform-tests PR due to failing upstream tests
Comment 8•6 years ago
|
||
Seems like this is legitimately failing upstream. Don't worry about the stability failures, but the idlharness selftest issues [1] are presumably real. If you have a fix that you can push to the wpt upstream branch that would be great; otherwise let me know and we'll work something out. I will probably have to force merge anyway since some stability jobs are timing out. Sorry for the slowness of the ping. [1] https://travis-ci.org/w3c/web-platform-tests/jobs/340791620
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 9•6 years ago
|
||
I pushed https://github.com/w3c/web-platform-tests/pull/9490/commits/06642989be7369b0f81d215dbbd4d76a5befdfb9 which will hopefully help....
Flags: needinfo?(bzbarsky)
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•