Closed Bug 1437255 Opened 2 years ago Closed 2 years ago

@@unscopable value objects in the DOM should have a null prototype

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview-Commit-ID: 9YjnPHe78Tg
Attachment #8949955 - Flags: review?(kyle)
Attachment #8949955 - Attachment is obsolete: true
Attachment #8949955 - Flags: review?(kyle)
Attachment #8949965 - Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6088a5f48ee
Use a null prototype for @@unscopables objects in the DOM.  r=qdot
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/9490 for changes under testing/web-platform/tests
https://hg.mozilla.org/mozilla-central/rev/a6088a5f48ee
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Can't merge web-platform-tests PR due to failing upstream tests
Can't merge web-platform-tests PR due to failing upstream tests
Seems like this is legitimately failing upstream. Don't worry about the stability failures, but the idlharness selftest issues [1] are presumably real. If you have a fix that you can push to the wpt upstream branch that would be great; otherwise let me know and we'll work something out. I will probably have to force merge anyway since some stability jobs are timing out.

Sorry for the slowness of the ping.

[1] https://travis-ci.org/w3c/web-platform-tests/jobs/340791620
Flags: needinfo?(bzbarsky)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.