1437335 - Manual proxy port configuration should disable when its option is not selected

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[magicp]

Attachment: connection-settings.png

Steps to reproduce:
1. Launch Nightly
2. Open about:preferences#general > Network Proxy > Settings...


Actual results:
Manual proxy port configuration is enabled even if its option is not selected when opening the dialog.


Expected results:
Manual proxy port configuration should disable when its option is not selected.


Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e57bbf2bbcf99bd3a5c6c8ddc62e5b6fb298c681&tochange=bb1b856328ab29b9452ef0bbbe0f5503fbac3ddb

Comment 1

[Sam Foster [:sfoster] (he/him)]

Bob, can you look into this?

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1437335 - Manual proxy port configuration should disable when its option is not selected,

This is a regression from bug 1429593. The code that was added to enable/disable controls on the page
depending on whether an extension is in control was being run when the page opened, which overrode
the code which disables specific controls based on the current proxy setting. All that is needed is
to call that code (which is in gConnectionsDialog.proxyTypeChanged()) if an extension is not in control
after the new code that was added. This patch fixes that issue, and includes a test verifying that
the manual controls are not enabled when the screen first opens.

Review commit: https://reviewboard.mozilla.org/r/223556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223556/

Comment 3

[Bob Silverberg [:bsilverberg]]

Jared, this is marked as a P1. I'm not sure how accurate that is, but the fix is very simple, so if you have a chance to look at it soon that would be great.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8954490 [details]
Bug 1437335 - Manual proxy port configuration should disable when its option is not selected,

https://reviewboard.mozilla.org/r/223556/#review229746

Normally this wouldn't be P1 but since it's a new regression we'd like to get them fixed in the same release that introduced it. Thanks for the quick patch!

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8954490 [details]
Bug 1437335 - Manual proxy port configuration should disable when its option is not selected,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223556/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78fb987e0b0
Manual proxy port configuration should disable when its option is not selected, r=jaws

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/e78fb987e0b0