Closed Bug 1437502 Opened 5 years ago Closed 5 years ago

Introduce AuthorStyles.

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

I want to add this struct and bindings before its actual uses because it allows me to play with it more freely.
Comment on attachment 8950191 [details]
Bug 1437502: Introduce AuthorStyles.

https://reviewboard.mozilla.org/r/219450/#review225402

Hmmm... so it's just a struct which is unused anywhere? That's not very exciting I guess.

Wouldn't it make more sense to make it part of a larger patchset so that how it's going to be used can be seen from later patches?

I guess I'm fine with this struct, and I can see how it might be used, but I really prefer to see its actual usage in code at the same time...

::: servo/components/style/author_styles.rs:24
(Diff revision 1)
> +#[cfg(feature = "gecko")]
> +unsafe impl HasFFI for AuthorStyles {
> +    type FFIType = ::gecko_bindings::structs::RawServoAuthorStyles;
> +}
> +#[cfg(feature = "gecko")]
> +unsafe impl HasSimpleFFI for PerDocumentStyleData {}
> +#[cfg(feature = "gecko")]
> +unsafe impl HasBoxFFI for PerDocumentStyleData {}

Don't you need to `use` these traits at the beginning of the file?

::: servo/components/style/lib.rs:90
(Diff revision 1)
>  
>  #[cfg(feature = "servo")] pub mod animation;
>  pub mod applicable_declarations;
>  #[allow(missing_docs)] // TODO.
>  #[cfg(feature = "servo")] pub mod attr;
> +#[cfg(feature = "servo")] pub mod author_styles;

Why is this servo-only?
Attachment #8950191 - Flags: review?(xidorn+moz)
Priority: -- → P2
Moved all of it to bug 1436059.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.