1437529 - xpcshell --verify does not run with http2server started

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Patrick McManus [:mcmanus]]

phase 1 shuts it down.. so --verify of any http2 test fails.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: Bug 1437529: --verify shudown node h2 server for phase2

Review commit: https://reviewboard.mozilla.org/r/219472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219472/

Comment 2

[Patrick McManus [:mcmanus]]

fwiw I think some of the main tests are rather stateful on the server side and will still fail the iterations --verify does.. but a substantial number of tests now pass (that can connect to the server now). I think daniel is going to file a bug for the stateful ones.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8950215 [details]
Bug 1437529: --verify shudown node h2 server for phase2

https://reviewboard.mozilla.org/r/219472/#review225314

Thanks, that looks fine. 

Sorry this was missed in the initial --verify implementation.

Comment 4

[Daniel Stenberg [:bagder]]

> I think daniel is going to file a bug for the stateful ones

I suspect my recent problem was rather my own test case's fault so right now it looks like I have nothing to add to this.

Without this --verify patch, the test cases for my pending bug 1434852 fail miserably and get a really bad look on try.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aab6c91fb14
verify shudown node h2 server for phase2 r=gbrown

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0aab6c91fb14

Comment 7

[Honza Bambas (:mayhemer)]

I think [1] is wrong.  I can see in the logs it's the place we kill the node server prematurely.

[1] https://searchfox.org/mozilla-central/rev/4234703a532006c5ef9ce09b4c487d88124526a0/testing/xpcshell/runxpcshelltests.py#1441

Comment 8

[Honza Bambas (:mayhemer)]

And it's just an indention problem (damn you python)

Comment 9

[Geoff Brown [:gbrown]]

Right. When verifying 2 or more tests in one run (as you are trying to do), the node server is shutdown after the first test is verified. That call should just be moved outside of the "for test_object in self.alltests" loop.