Closed Bug 1437529 Opened 4 years ago Closed 4 years ago

xpcshell --verify does not run with http2server started

Categories

(Testing :: XPCShell Harness, defect)

Version 3
defect
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

phase 1 shuts it down.. so --verify of any http2 test fails.
fwiw I think some of the main tests are rather stateful on the server side and will still fail the iterations --verify does.. but a substantial number of tests now pass (that can connect to the server now). I think daniel is going to file a bug for the stateful ones.
Comment on attachment 8950215 [details]
Bug 1437529: --verify shudown node h2 server for phase2

https://reviewboard.mozilla.org/r/219472/#review225314

Thanks, that looks fine. 

Sorry this was missed in the initial --verify implementation.
Attachment #8950215 - Flags: review?(gbrown) → review+
> I think daniel is going to file a bug for the stateful ones

I suspect my recent problem was rather my own test case's fault so right now it looks like I have nothing to add to this.

Without this --verify patch, the test cases for my pending bug 1434852 fail miserably and get a really bad look on try.
Pushed by mcmanus@ducksong.com:
https://hg.mozilla.org/integration/autoland/rev/0aab6c91fb14
verify shudown node h2 server for phase2 r=gbrown
https://hg.mozilla.org/mozilla-central/rev/0aab6c91fb14
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
I think [1] is wrong.  I can see in the logs it's the place we kill the node server prematurely.

[1] https://searchfox.org/mozilla-central/rev/4234703a532006c5ef9ce09b4c487d88124526a0/testing/xpcshell/runxpcshelltests.py#1441
And it's just an indention problem (damn you python)
Blocks: 1438583
Right. When verifying 2 or more tests in one run (as you are trying to do), the node server is shutdown after the first test is verified. That call should just be moved outside of the "for test_object in self.alltests" loop.
Assignee: nobody → mcmanus
You need to log in before you can comment on or make changes to this bug.