1437561 - Upgrade lazy_static crate

Status: RESOLVED DUPLICATE of bug 1438954

(Testing :: geckodriver, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

We will want to upgrade our lazy_static dependency because another
crate in our dependency tree depends on a different version.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1437561 - Upgrade lazy_static dependency.

Another crate in geckodriver's dependency tree relies on a different
version of lazy_static,  meaning we end up compiling lazy_static twice.
By relying on the same version we can reduce build time marginally.

This changes geckodriver to rely on >=1.0.0 and <2.0.0, which means
it is easier to automatically upgrade this crate in the future.

Review commit: https://reviewboard.mozilla.org/r/219508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219508/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1437561 - Drop lazy_static v0.1.16.

Review commit: https://reviewboard.mozilla.org/r/219510/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219510/

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8950249 [details]
Bug 1437561 - Upgrade lazy_static dependency.

https://reviewboard.mozilla.org/r/219508/#review225988

::: testing/geckodriver/Cargo.toml:16
(Diff revision 1)
>  
>  [dependencies]
>  chrono = "^0.2"
>  clap = { version = "^2.19", default-features = false, features = ["suggestions", "wrap_help"] }
>  hyper = "0.10"
> -lazy_static = "0.1"
> +lazy_static = "^1"

You don't need the caret here. It's implied by default.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8950251 [details]
Bug 1437561 - Drop lazy_static v0.1.16.

https://reviewboard.mozilla.org/r/219510/#review225992

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8950249 [details]
Bug 1437561 - Upgrade lazy_static dependency.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219508/diff/1-2/

Comment 6

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8950251 [details]
Bug 1437561 - Drop lazy_static v0.1.16.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219510/diff/1-2/

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fabe597de50915cd843ab9cc9ee0465044207618 -d 7270c9ee964b: rebasing 447328:fabe597de509 "Bug 1437561 - Upgrade lazy_static dependency. r=jgraham"
merging testing/geckodriver/Cargo.lock
merging testing/geckodriver/Cargo.toml
warning: conflicts while merging testing/geckodriver/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/geckodriver/Cargo.toml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8950249 [details]
Bug 1437561 - Upgrade lazy_static dependency.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219508/diff/2-3/

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8950251 [details]
Bug 1437561 - Drop lazy_static v0.1.16.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219510/diff/2-3/

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s e6616114e82535cc3d242f7261cc7d3bdb6e23b6 -d d8bb0ab25ecb: rebasing 447333:e6616114e825 "Bug 1437561 - Upgrade lazy_static dependency. r=jgraham"
merging testing/geckodriver/Cargo.lock
merging testing/geckodriver/Cargo.toml
warning: conflicts while merging testing/geckodriver/Cargo.lock! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/geckodriver/Cargo.toml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)