1437571 - Upgrade winreg dependency

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

mozrunner is currently on winreg v0.3.4 but the latest version is v0.5.0.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1437571 - Upgrade to winreg v0.5.0.

Output from "./mach vendor rust":

    Removing advapi32-sys v0.1.2
    Removing kernel32-sys v0.1.4
    Removing ktmw32-sys v0.1.0
      Adding winapi v0.3.4
      Adding winapi-i686-pc-windows-gnu v0.4.0
      Adding winapi-x86_64-pc-windows-gnu v0.4.0
    Updating winreg v0.3.5 -> v0.5.0

Review commit: https://reviewboard.mozilla.org/r/219518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219518/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1437571 - Bump winreg dependencies.

Made this a separate commit as it would be impossible to review otherwise.

Review commit: https://reviewboard.mozilla.org/r/219520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219520/

Comment 3

[Andreas Tolfsen ❲:ato❳]

One thing I’m a bit uncertain about regardnig this change is that
it adds ~135k lines.  I’m sure the improvements are for the better,
but this presumably also means we need to compile a lot more things.
Since the current code is functioning as intended, I’m fine with
an r- on this patch.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8950260 [details]
Bug 1437571 - Upgrade to winreg v0.5.0.

https://reviewboard.mozilla.org/r/219518/#review226006

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8950261 [details]
Bug 1437571 - Bump winreg dependencies.

https://reviewboard.mozilla.org/r/219520/#review226008

Still is impossible to review :p I assume this was just the result of the vendor command.

Comment 6

[Andreas Tolfsen ❲:ato❳]

It looks like with winapi 0.3 you can pick what features you want to
include. winreg only picks a couple of these [1] so this should be
safe to land.

I also compared the average build times on TC with this patch
applied, and couldn’t see any significant change.

  [1] https://github.com/gentoo90/winreg-rs/blob/master/Cargo.toml#L13

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8920ee351e02
Upgrade to winreg v0.5.0. r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b1a56d918b
Bump winreg dependencies. r=jgraham

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8920ee351e02
https://hg.mozilla.org/mozilla-central/rev/f9b1a56d918b