Closed Bug 1437571 Opened 2 years ago Closed 2 years ago
Upgrade winreg dependency
mozrunner is currently on winreg v0.3.4 but the latest version is v0.5.0.
One thing I’m a bit uncertain about regardnig this change is that it adds ~135k lines. I’m sure the improvements are for the better, but this presumably also means we need to compile a lot more things. Since the current code is functioning as intended, I’m fine with an r- on this patch.
Comment on attachment 8950260 [details] Bug 1437571 - Upgrade to winreg v0.5.0. https://reviewboard.mozilla.org/r/219518/#review226006
Attachment #8950260 - Flags: review?(james) → review+
Comment on attachment 8950261 [details] Bug 1437571 - Bump winreg dependencies. https://reviewboard.mozilla.org/r/219520/#review226008 Still is impossible to review :p I assume this was just the result of the vendor command.
Attachment #8950261 - Flags: review?(james) → review+
It looks like with winapi 0.3 you can pick what features you want to include. winreg only picks a couple of these  so this should be safe to land. I also compared the average build times on TC with this patch applied, and couldn’t see any significant change.  https://github.com/gentoo90/winreg-rs/blob/master/Cargo.toml#L13
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/8920ee351e02 Upgrade to winreg v0.5.0. r=jgraham https://hg.mozilla.org/integration/mozilla-inbound/rev/f9b1a56d918b Bump winreg dependencies. r=jgraham
You need to log in before you can comment on or make changes to this bug.