Closed
Bug 1437679
Opened 6 years ago
Closed 6 years ago
Intermittent PROCESS-CRASH | Main app process exited normally | application crashed [@ ProfileBuffer::DuplicateLastSample(int,mozilla::TimeStamp const &,mozilla::Maybe<unsigned __int64> &)]
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox-esr52 unaffected, firefox59 unaffected, firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: mstange)
References
Details
(Keywords: crash, intermittent-failure)
Crash Data
Filed by: apavel [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=161708477&repo=autoland https://queue.taskcluster.net/v1/task/SQ6gzfd5RMK6ZvBh33MlRQ/runs/0/artifacts/public/logs/live_backing.log 16:02:07 INFO - 764 INFO TEST-START | devtools/server/tests/browser/browser_webextension_inspected_window.js 16:02:08 INFO - GECKO(6040) | console.error: 16:02:08 INFO - GECKO(6040) | Reload already in progress. Ignored inspectedWindow.reload for moz-extension://fake-webextension-uuid/fake-caller-script.js:1 16:02:08 INFO - GECKO(6040) | console.error: 16:02:08 INFO - GECKO(6040) | Message: Error: devtools.inspectedWindow.reload on http://test1.example.org/browser/devtools/server/tests/browser//inspectedwindow-reload-target.sjs?test=injected-script&frames=3&stop=windowStop has been interrupted 16:02:08 INFO - GECKO(6040) | Stack: 16:02:08 INFO - GECKO(6040) | onStateChange@resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/webextension-inspected-window.js:153:19 16:02:08 INFO - GECKO(6040) | @http://test1.example.org/browser/devtools/server/tests/browser//inspectedwindow-reload-target.sjs?test=injected-script&frames=3&stop=windowStop:15:1 16:02:08 INFO - GECKO(6040) | MEMORY STAT | vsize 747MB | vsizeMaxContiguous 667MB | residentFast 242MB | heapAllocated 107MB 16:02:08 INFO - 765 INFO TEST-OK | devtools/server/tests/browser/browser_webextension_inspected_window.js | took 1712ms 16:02:08 INFO - 766 INFO checking window state 16:02:10 INFO - GECKO(6040) | Completed ShutdownLeaks collections in process 3504 16:02:10 INFO - GECKO(6040) | Completed ShutdownLeaks collections in process 3760 16:02:10 INFO - GECKO(6040) | Completed ShutdownLeaks collections in process 1668 16:02:10 INFO - GECKO(6040) | Completed ShutdownLeaks collections in process 2268 16:02:10 INFO - GECKO(6040) | Completed ShutdownLeaks collections in process 6040 16:02:10 INFO - 767 INFO TEST-START | Shutdown 16:02:10 INFO - 768 INFO Browser Chrome Test Summary 16:02:10 INFO - 769 INFO Passed: 940 16:02:10 INFO - 770 INFO Failed: 0 16:02:10 INFO - 771 INFO Todo: 0 16:02:10 INFO - 772 INFO Mode: e10s 16:02:10 INFO - 773 INFO *** End BrowserChrome Test Results *** 16:02:10 INFO - GECKO(6040) | [Parent 6040, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Child 2268, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Child 2268, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Parent 6040, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Parent 6040, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Child 3504, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | [Child 3504, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346 16:02:10 INFO - GECKO(6040) | *** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping 16:02:11 INFO - GECKO(6040) | 1518451331032 Marionette DEBUG Received observer notification xpcom-shutdown 16:02:11 INFO - GECKO(6040) | 1518451331033 Marionette DEBUG New connections will no longer be accepted 16:05:16 INFO - WARNING | IO Completion Port failed to signal process shutdown 16:05:16 INFO - Parent process 6040 exited with children alive: 16:05:16 INFO - PIDS: 4112 16:05:16 INFO - Attempting to kill them, but no guarantee of success 16:05:16 INFO - TEST-INFO | Main app process: exit 0 16:05:16 INFO - runtests.py | Application ran for: 0:03:59.241000 16:05:16 INFO - zombiecheck | Reading PID log: c:\users\genericworker\appdata\local\temp\tmprgxh4dpidlog 16:05:16 INFO - ==> process 6040 launched child process 3056 ("Z:\task_1518450906\build\application\firefox\firefox.exe" -contentproc --channel="6040.0.1294353207\467638792" -childID 1 -isForBrowser -intPrefs 6:50|7:-1|35:1000|43:0|44:5|45:0|52:0|58:128|59:10000|64:0|66:400|67:1|68:0|69:0|70:100|75:0|76:120|77:120|162:2|163:1|167:60|168:30|169:1000|178:0|180:0|194:32|195:256|196:5|209:10000|230:24|231:32768|233:0|234:0|243:2|247:1048576|249:100|250:5000|252:600|254:1|262:20|279:5|283:0|291:60000|309:300|310:30| -boolPrefs 1:0|2:0|4:1|5:1|25:1|28:1|29:1|30:1|32:1|33:1|34:1|37:1|38:1|39:1|42:0|46:1|47:0|48:0|49:1|50:1|51:1|53:0|56:1|57:1|60:1|61:0|62:0|63:0|65:0|71:1|72:1|73:1|74:1|78:1|79:1|80:0|81:0|82:1|83:1|84:1|85:1|86:1|89:0|90:0|93:1|94:1|98:1|99:1|100:0|101:1|102:1|103:1|104:0|105:0|107:0|108:0|109:1|110:1|111:1|114:1|115:1|116:1|117:1|118:1|119:0|120:1|121:1|122:0|123:0|124:1|125:1|126:0|127:1|128:1|129:1|131:1|132:0|133:1|134:1|135:1|136:0|137:0|138:0|139:1|140:1|141:1|142:1|143:1|144:1|145:1|146:1|147:1|148:1|149:1|150:0|151:1|152:1|153:0|154:1|155:1|156:0|157:0|158:1|159:1|160:1|161:1|164:1|165:0|172:0|175:0|176:0|177:1|181:1|184:0|185:1|187:1|189:0|191:1|193:1|197:1|198:0|199:1|200:1|201:0|204:1|208:1|210:0|211:0|213:1|216:0|222:0|223:1|224:0|225:1|228:0|229:0|232:1|235:0|237:1|238:1|240:1|241:0|248:1|251:1|256:0|257:0|258:0|259:1|260:1|261:0|266:1|269:1|270:1|271:1|272:1|273:1|274:0|275:1|281:0|284:0|285:1|286:1|287:0|288:1|289:1|290:1|292:0|293:0|295:0|304:1|305:1|306:0|307:0|308:0| -stringPrefs "3:7;default|215:4;0.01|226:332; ����!==> process 6040 launched child process 3504 ("Z:\task_1518450906\build\application\firefox\firefox.exe" -contentproc --channel="6040.6.1102794583\628553640" -childID 2 -isForBrowser -intPrefs 6:50|7:-1|35:1000|43:0|44:5|45:0|52:0|58:128|59:10000|64:0|66:400|67:1|68:0|69:0|70:100|75:0|76:120|77:120|162:2|163:1|167:60|168:30|169:1000|178:0|180:0|194:32|195:256|196:5|209:10000|230:24|231:32768|233:0|234:0|243:2|247:1048576|249:100|250:5000|252:600|254:1|262:20|279:5|283:0|291:60000|309:300|310:30| -boolPrefs 1:0|2:0|4:1|5:1|25:1|28:1|29:1|30:1|32:1|33:1|34:1|37:1|38:1|39:1|42:0|46:1|47:0|48:0|49:1|50:1|51:1|53:0|56:1|57:1|60:1|61:0|62:0|63:0|65:0|71:1|72:1|73:1|74:1|78:1|79:1|80:0|81:0|82:1|83:1|84:1|85:1|86:1|89:0|90:0|93:1|94:1|98:1|99:1|100:0|101:1|102:1|103:1|104:0|105:0|107:0|108:0|109:1|110:1|111:1|114:1|115:1|116:1|117:1|118:1|119:0|120:1|121:1|122:0|123:0|124:1|125:1|126:0|127:1|128:1|129:1|131:1|132:0|133:1|134:1|135:1|136:0|137:0|138:0|139:1|140:1|141:1|142:1|143:1|144:1|145:1|146:1|147:1|148:1|149:1|150:0|151:1|152:1|153:0|154:1|155:1|156:0|157:0|158:1|159:1|160:1|161:1|164:1|165:0|172:0|175:0|176:0|177:1|181:1|184:0|185:1|187:1|189:0|191:1|193:1|197:1|198:0|199:1|200:1|201:0|204:1|208:1|210:0|211:0|213:1|216:0|222:0|223:1|224:0|225:1|228:0|229:0|232:1|235:0|237:1|238:1|240:1|241:0|248:1|251:1|256:0|257:0|258:0|259:1|260:1|261:0|266:1|269:1|270:1|271:1|272:1|273:1|274:0|275:1|281:0|284:0|285:1|286:1|287:0|288:1|289:1|290:1|292:0|293:0|295:0|304:1|305:1|306:0|307:0|308:0| -stringPrefs "3:7;default|215:4;0.01|226:332; ����!==> process 6040 launched child process 3760 ("Z:\task_1518450906\build\application\firefox\firefox.exe" -contentproc --channel="6040.12.111873461\1147503270" -childID 3 -isForBrowser -intPrefs 6:50|7:-1|35:1000|43:0|44:5|45:0|52:0|58:128|59:10000|64:0|66:400|67:1|68:0|69:0|70:100|75:0|76:120|77:120|162:2|163:1|167:60|168:30|169:1000|178:0|180:0|194:32|195:256|196:5|209:10000|230:24|231:32768|233:0|234:0|243:2|247:1048576|249:100|250:5000|252:600|254:1|262:20|279:5|283:0|291:60000|309:300|310:30| -boolPrefs 1:0|2:0|4:1|5:1|25:1|28:1|29:1|30:1|32:1|33:1|34:1|37:1|38:1|39:1|42:0|46:1|47:0|48:0|49:1|50:1|51:1|53:0|56:1|57:1|60:1|61:0|62:0|63:0|65:0|71:1|72:1|73:1|74:1|78:1|79:1|80:0|81:0|82:1|83:1|84:1|85:1|86:1|89:0|90:0|93:1|94:1|98:1|99:1|100:0|101:1|102:1|103:1|104:0|105:0|107:0|108:0|109:1|110:1|111:1|114:1|115:1|116:1|117:1|118:1|119:0|120:1|121:1|122:0|123:0|124:1|125:1|126:0|127:1|128:1|129:1|131:1|132:0|133:1|134:1|135:1|136:0|137:0|138:0|139:1|140:1|141:1|142:1|143:1|144:1|145:1|146:1|147:1|148:1|149:1|150:0|151:1|152:1|153:0|154:1|155:1|156:0|157:0|158:1|159:1|160:1|161:1|164:1|165:0|172:0|175:0|176:0|177:1|181:1|184:0|185:1|187:1|189:0|191:1|193:1|197:1|198:0|199:1|200:1|201:0|204:1|208:1|210:0|211:0|213:1|216:0|222:0|223:1|224:0|225:1|228:0|229:0|232:1|235:0|237:1|238:1|240:1|241:0|248:1|251:1|256:0|257:0|258:0|259:1|260:1|261:0|266:1|269:1|270:1|271:1|272:1|273:1|274:0|275:1|281:0|284:0|285:1|286:1|287:0|288:1|289:1|290:1|292:0|293:0|295:0|304:1|305:1|306:0|307:0|308:0| -stringPrefs "3:7;default|215:4;0.01|226:332; ����!==> process 6040 launched child process 1668 ("Z:\task_1518450906\build\application\firefox\firefox.exe" -contentproc --channel="6040.18.1477566034\2144564609" -childID 4 -isForBrowser -intPrefs 6:50|7:-1|35:1000|43:0|44:5|45:0|52:0|58:128|59:10000|64:0|66:400|67:1|68:0|69:0|70:100|75:0|76:120|77:120|162:2|163:1|167:60|168:30|169:1000|178:0|180:0|194:32|195:256|196:5|209:10000|230:24|231:32768|233:0|234:0|243:2|247:1048576|249:100|250:5000|252:600|254:1|262:20|279:5|283:0|291:60000|309:300|310:30| -boolPrefs 1:0|2:0|4:1|5:1|25:1|28:1|29:1|30:1|32:1|33:1|34:1|37:1|38:1|39:1|42:0|46:1|47:0|48:0|49:1|50:1|51:1|53:0|56:1|57:1|60:1|61:0|62:0|63:0|65:0|71:1|72:1|73:1|74:1|78:1|79:1|80:0|81:0|82:1|83:1|84:1|85:1|86:1|89:0|90:0|93:1|94:1|98:1|99:1|100:0|101:1|102:1|103:1|104:0|105:0|107:0|108:0|109:1|110:1|111:1|114:1|115:1|116:1|117:1|118:1|119:0|120:1|121:1|122:0|123:0|124:1|125:1|126:0|127:1|128:1|129:1|131:1|132:0|133:1|134:1|135:1|136:0|137:0|138:0|139:1|140:1|141:1|142:1|143:1|144:1|145:1|146:1|147:1|148:1|149:1|150:0|151:1|152:1|153:0|154:1|155:1|156:0|157:0|158:1|159:1|160:1|161:1|164:1|165:0|172:0|175:0|176:0|177:1|181:1|184:0|185:1|187:1|189:0|191:1|193:1|197:1|198:0|199:1|200:1|201:0|204:1|208:1|210:0|211:0|213:1|216:0|222:0|223:1|224:0|225:1|228:0|229:0|232:1|235:0|237:1|238:1|240:1|241:0|248:1|251:1|256:0|257:0|258:0|259:1|260:1|261:0|266:1|269:1|270:1|271:1|272:1|273:1|274:0|275:1|281:0|284:0|285:1|286:1|287:0|288:1|289:1|290:1|292:0|293:0|295:0|304:1|305:1|306:0|307:0|308:0| -stringPrefs "3:7;default|215:4;0.01|226:332; ����!==> process 6040 launched child process 2268 ("Z:\task_1518450906\build\application\firefox\firefox.exe" -contentproc --channel="6040.24.858012484\174921761" -childID 5 -isForBrowser -intPrefs 6:50|7:-1|35:1000|43:0|44:5|45:0|52:0|58:128|59:10000|64:0|66:400|67:1|68:0|69:0|70:100|75:0|76:120|77:120|162:2|163:1|167:60|168:30|169:1000|178:0|180:0|194:32|195:256|196:5|209:10000|230:24|231:32768|233:0|234:0|243:2|247:1048576|249:100|250:5000|252:600|254:1|262:20|279:5|283:0|291:60000|309:300|310:30| -boolPrefs 1:0|2:0|4:1|5:1|25:1|28:1|29:1|30:1|32:1|33:1|34:1|37:1|38:1|39:1|42:0|46:1|47:0|48:0|49:1|50:1|51:1|53:0|56:1|57:1|60:1|61:0|62:0|63:0|65:0|71:1|72:1|73:1|74:1|78:1|79:1|80:0|81:0|82:1|83:1|84:1|85:1|86:1|89:0|90:0|93:1|94:1|98:1|99:1|100:0|101:1|102:1|103:1|104:0|105:0|107:0|108:0|109:1|110:1|111:1|114:1|115:1|116:1|117:1|118:1|119:0|120:1|121:1|122:0|123:0|124:1|125:1|126:0|127:1|128:1|129:1|131:1|132:0|133:1|134:1|135:1|136:0|137:0|138:0|139:1|140:1|141:1|142:1|143:1|144:1|145:1|146:1|147:1|148:1|149:1|150:0|151:1|152:1|153:0|154:1|155:1|156:0|157:0|158:1|159:1|160:1|161:1|164:1|165:0|172:0|175:0|176:0|177:1|181:1|184:0|185:1|187:1|189:0|191:1|193:1|197:1|198:0|199:1|200:1|201:0|204:1|208:1|210:0|211:0|213:1|216:0|222:0|223:1|224:0|225:1|228:0|229:0|232:1|235:0|237:1|238:1|240:1|241:0|248:1|251:1|256:0|257:0|258:0|259:1|260:1|261:0|266:1|269:1|270:1|271:1|272:1|273:1|274:0|275:1|281:0|284:0|285:1|286:1|287:0|288:1|289:1|290:1|292:0|293:0|295:0|304:1|305:1|306:0|307:0|308:0| -stringPrefs "3:7;default|215:4;0.01|226:332; ����! 16:05:16 INFO - zombiecheck | Checking for orphan process with PID: 3056 16:05:16 INFO - mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/KSRmz9nOTxiF7qFaHGDFSQ/artifacts/public/build/target.crashreporter-symbols.zip 16:05:19 INFO - mozcrash Copy/paste: Z:\task_1518450906\build\win32-minidump_stackwalk.exe c:\users\genericworker\appdata\local\temp\tmpsh62t1.mozrunner\minidumps\bebf590b-3e2e-403a-a783-6537e7fc065e.dmp c:\users\genericworker\appdata\local\temp\tmp_0lqgg 16:05:27 INFO - mozcrash Saved minidump as Z:\task_1518450906\build\blobber_upload_dir\bebf590b-3e2e-403a-a783-6537e7fc065e.dmp 16:05:27 INFO - mozcrash Saved app info as Z:\task_1518450906\build\blobber_upload_dir\bebf590b-3e2e-403a-a783-6537e7fc065e.extra 16:05:27 WARNING - PROCESS-CRASH | Main app process exited normally | application crashed [@ ProfileBuffer::DuplicateLastSample(int,mozilla::TimeStamp const &,mozilla::Maybe<unsigned __int64> &)] 16:05:27 INFO - Crash dump filename: c:\users\genericworker\appdata\local\temp\tmpsh62t1.mozrunner\minidumps\bebf590b-3e2e-403a-a783-6537e7fc065e.dmp 16:05:27 INFO - Operating system: Windows NT 16:05:27 INFO - 6.1.7601 Service Pack 1 16:05:27 INFO - CPU: x86 16:05:27 INFO - GenuineIntel family 6 model 63 stepping 2 16:05:27 INFO - 8 CPUs 16:05:27 INFO - GPU: UNKNOWN 16:05:27 INFO - Crash reason: EXCEPTION_BREAKPOINT 16:05:27 INFO - Crash address: 0x5a29f1f4 16:05:27 INFO - Assertion: Unknown assertion type 0x00000000 16:05:27 INFO - Process uptime: 37 seconds 16:05:27 INFO - Thread 41 (crashed) 16:05:27 INFO - 0 xul.dll!ProfileBuffer::DuplicateLastSample(int,mozilla::TimeStamp const &,mozilla::Maybe<unsigned __int64> &) [ProfileBufferEntry.cpp:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 1015 + 0xb] 16:05:27 INFO - eip = 0x5a29f1f4 esp = 0x0f72f7f0 ebp = 0x0f72f85c ebx = 0x00000000 16:05:27 INFO - esi = 0x013181f0 edi = 0x05d01a90 eax = 0x683345c4 ecx = 0x0ed00000 16:05:27 INFO - edx = 0x0f72f950 efl = 0x00000293 16:05:27 INFO - Found by: given as instruction pointer in context 16:05:27 INFO - 1 xul.dll!SamplerThread::Run() [platform.cpp:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 1999 + 0x3c] 16:05:27 INFO - eip = 0x5a2a1239 esp = 0x0f72f864 ebp = 0x0f72f968 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 2 xul.dll!ThreadEntry [platform-win32.cpp:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 199 + 0x8] 16:05:27 INFO - eip = 0x5a2a3cca esp = 0x0f72f970 ebp = 0x0f72f970 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 3 ucrtbase.dll!_o___stdio_common_vsprintf_s + 0x7d 16:05:27 INFO - eip = 0x61ebaa5d esp = 0x0f72f978 ebp = 0x0f72f9ac 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 4 kernel32.dll!BaseThreadInitThunk + 0x12 16:05:27 INFO - eip = 0x76163c45 esp = 0x0f72f9b4 ebp = 0x0f72f9b8 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 5 mozglue.dll!patched_BaseThreadInitThunk [WindowsDllBlocklist.cpp:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 835 + 0x6] 16:05:27 INFO - eip = 0x6831c27d esp = 0x0f72f9c0 ebp = 0x0f72f9d4 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 6 ntdll.dll!__RtlUserThreadStart + 0x27 16:05:27 INFO - eip = 0x776d37f5 esp = 0x0f72f9dc ebp = 0x0f72fa14 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 7 ntdll.dll!_RtlUserThreadStart + 0x1b 16:05:27 INFO - eip = 0x776d37c8 esp = 0x0f72fa1c ebp = 0x0f72fa2c 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - Thread 0 16:05:27 INFO - 0 ntdll.dll!KiFastSystemCallRet + 0x0 16:05:27 INFO - eip = 0x776b70b4 esp = 0x0017eb84 ebp = 0x0017ebe8 ebx = 0x00000000 16:05:27 INFO - esi = 0x01302500 edi = 0x00000000 eax = 0x0017ec50 ecx = 0x0131d1f0 16:05:27 INFO - edx = 0x5af18960 efl = 0x00000217 16:05:27 INFO - Found by: given as instruction pointer in context 16:05:27 INFO - 1 ntdll.dll!NtWaitForSingleObject + 0xc 16:05:27 INFO - eip = 0x776b6a24 esp = 0x0017eb88 ebp = 0x0017ebe8 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 2 ntdll.dll!RtlpWaitOnCriticalSection + 0xc4 16:05:27 INFO - eip = 0x776a2264 esp = 0x0017eb8c ebp = 0x0017ebe8 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 3 ntdll.dll!EtwEventEnabled + 0xd9 16:05:27 INFO - eip = 0x776a2148 esp = 0x0017ebf0 ebp = 0x0017ec10 ebx = 0x0131ec10 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 4 mozglue.dll!mozilla::detail::MutexImpl::lock() [Mutex_windows.cpp:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 42 + 0x7] 16:05:27 INFO - eip = 0x683199d7 esp = 0x0017ec18 ebp = 0x0017ec64 ebx = 0x00000001 16:05:27 INFO - Found by: call frame info 16:05:27 INFO - 5 xul.dll!mozilla::detail::RunnableFunction<<lambda_ce3eea3f1f514760b4c92e4c2386f233> >::Run [nsThreadUtils.h:efd7d596ff1bc5b5a9c2c4ac7d5488a97a626eeb : 536 + 0x5] 16:05:27 INFO - eip = 0x5a2a1088 esp = 0x0017ec28 ebp = 0x0017ec64 16:05:27 INFO - Found by: call frame info
Comment 1•6 years ago
|
||
Hey Markus, this looks like a crash in the Gecko Profiler. What do you think?
Flags: needinfo?(mstange)
Comment 2•6 years ago
|
||
In [1] do you think we should use `aLastSample.isSome()` in the condition instead of just `aLastSample`, which should be always true because we use a reference? [1] https://searchfox.org/mozilla-central/rev/9d47b5fb14152865ad1375eb3ee2e571d81ecdb9/tools/profiler/core/ProfileBufferEntry.cpp#1002
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #2) > instead of just `aLastSample`, which should be always true because we use a > reference? It's not always true - you can't null-check a reference. Checking a reference does the same as checking the referred-to value. Example: bool someValue = false; bool& reference = someValue; "if (reference)" now means the same as "if (someValue)". So in our case, "if (aLastSample)" evaluates "Maybe::operator bool" on the Maybe value that aLastSample refers to, so it's equivalent to "if (aLastSample.isSome())". The crash that we're hitting in this bug is the MOZ_RELEASE_ASSERT a bit lower down: > MOZ_RELEASE_ASSERT(GetEntry(lastSampleStartPos).IsThreadId() && > GetEntry(lastSampleStartPos).u.mInt == aThreadId); https://searchfox.org/mozilla-central/source/tools/profiler/core/ProfileBufferEntry.cpp#1049-1050 I think what's happening here is that aLastSample refers to a position from a previous profiler buffer, not from the current profiler buffer. As far as I can see, we currently don't clear ThreadInfo::mLastSample when the profiler is stopped and the buffer is destroyed. The patches in bug 1437428 will fix that by moving mLastSample to ProfiledThreadData, which is destroyed when the profiler is stopped. My current hope is that relanding bug 1437428 will fix this crash.
Depends on: 1437428
Flags: needinfo?(mstange)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Priority: P5 → P1
Updated•6 years ago
|
Crash Signature: [@ ProfileBuffer::DuplicateLastSample(int,mozilla::TimeStamp const &,mozilla::Maybe<unsigned __int64> &)] → [@ ProfileBuffer::DuplicateLastSample(int,mozilla::TimeStamp const &,mozilla::Maybe<unsigned __int64> &)]
[@ ProfileBuffer::DuplicateLastSample]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 7•6 years ago
|
||
No more crashes in the last 7 days. Fixed by bug 1437428.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
status-firefox59:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•