1437728 - toolkit/xre/test/browser_checkcfgstatus.js fails after bug 1193394

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=701a987d4fcddd24a4f67f08df6f9ee2b9b81f3a&selectedJob=161720996
>  FAIL | toolkit/xre/test/browser_checkcfgstatus.js | Uncaught exception
at chrome://browser/content/tabbrowser.xml:4500 - TypeError: initialBrowser.frameLoader.tabParent is null
> Stack trace: init@chrome://browser/content/tabbrowser.xml:4500:1
> _getSwitcher@chrome://browser/content/tabbrowser.xml:5352:11
> set_selectedIndex@chrome://browser/content/tabbrowser.xml:8598:11
> set_selectedPanel@chrome://global/content/bindings/tabbox.xml:674:13
> set_selectedIndex@chrome://global/content/bindings/tabbox.xml:392:15
> set_selectedItem@chrome://global/content/bindings/tabbox.xml:424:34
> set_selectedTab@chrome://global/content/bindings/tabbox.xml:100:15
> set_selectedTab@chrome://browser/content/tabbrowser.xml:3958:11
> _blurTab@chrome://browser/content/tabbrowser.xml:3505:32
> _beginRemoveTab@chrome://browser/content/tabbrowser.xml:3219:13
> removeTab@chrome://browser/content/tabbrowser.xml:3123:18
> removeTab@resource://testing-common/BrowserTestUtils.jsm:1111:7
> withNewTab@resource://testing-common/BrowserTestUtils.jsm:107:13
> async*test_cfg_enabled@chrome://mochitests/content/browser/toolkit/xre/test/browser_checkcfgstatus.js:32:9
> Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1067:21
> Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
> Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
> SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

it's too early to remove tab, in BrowserTestUtils.withNewTab
it should wait for at least a tick.

Comment 1

[Tooru Fujisawa [:arai]]

try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf65618d3a898f77d69caa1e0ba2849026097a9d

Comment 2

[Tooru Fujisawa [:arai]]

uh, I cannot trigger new jobs due to bug 1437738 :P

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Wait for a tick before removing tab in BrowserTestUtils.withNewTab.

Added `await TestUtils.waitForTick();` before removing tab,
so that even if `taskFn` returns within a tick, the newly opened tab won't be removed in the same tick.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e480e3b7819d
Wait for a tick before removing tab in BrowserTestUtils.withNewTab. r=gijs

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e480e3b7819d