1437795 - Reset TextInputListener on nsTextEditorState::Clear()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P1)

Description

[Makoto Kato [:m_kato]]

nsTextEditorState is reusable object by HTMLInputElement.  When it is unused, it will call Unlink method to remove dependency of HTMLInputElement etc.

So we should reset TextInputListener on EditorBase too on Unlink because anyone might call nsTextEditorState from TextInputListener.  Actually, OnSelectionChange doesn't use it...

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1437795 - Reset TextInputListener on nsTextEditorState::Clear().

nsTextEditorState is reusable object by HTMLInputElement.  When it is unused,
it will call Unlink method to remove dependency of HTMLInputElement etc.

So we should reset TextInputListener on Editor too on Unlink because anyone might call nsTextEditorState from TextInputListener.

Review commit: https://reviewboard.mozilla.org/r/219792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219792/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8950511 [details]
Bug 1437795 - Reset TextInputListener on nsTextEditorState::Clear().

https://reviewboard.mozilla.org/r/219792/#review225506

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f075ca0c869
Reset TextInputListener on nsTextEditorState::Clear(). r=masayuki

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9f075ca0c869