Closed Bug 1437795 Opened 2 years ago Closed 2 years ago

Reset TextInputListener on nsTextEditorState::Clear()

Categories

(Core :: DOM: Editor, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

nsTextEditorState is reusable object by HTMLInputElement.  When it is unused, it will call Unlink method to remove dependency of HTMLInputElement etc.

So we should reset TextInputListener on EditorBase too on Unlink because anyone might call nsTextEditorState from TextInputListener.  Actually, OnSelectionChange doesn't use it...
Comment on attachment 8950511 [details]
Bug 1437795 - Reset TextInputListener on nsTextEditorState::Clear().

https://reviewboard.mozilla.org/r/219792/#review225506
Attachment #8950511 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9f075ca0c869
Reset TextInputListener on nsTextEditorState::Clear(). r=masayuki
https://hg.mozilla.org/mozilla-central/rev/9f075ca0c869
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.