Closed Bug 1437818 Opened 6 years ago Closed 6 years ago

Enable ESLint rule react/no-array-index-key

Categories

(Tree Management :: Treeherder: Frontend, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: camd)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

One of the ESLint rules we've not yet enabled is this one:
https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md

It looks like it helps prevent incorrect usage of `key`, which can cause perf issues due to unnecessary renders.

Cameron - would you mind taking a look at this? I wonder if it might help improve some of the performance issues you were seeing?
Flags: needinfo?(cdawson)
Sure, I'll take a look.  :)
Assignee: nobody → cdawson
Flags: needinfo?(cdawson)
Comment on attachment 8957313 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3322

I finally got around to doing this.  :)
Attachment #8957313 - Flags: review?(emorley)
Attachment #8957313 - Flags: review?(emorley) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: